Refactor hvp

[junyu0312]

Summary by CodeRabbit

• Refactor
  • Simplified internal virtual CPU management architecture by removing trait-based storage constraints and reorganizing CPU instance handling. These changes maintain existing functionality while improving code flexibility and reducing compilation constraints.

[coderabbitai]

Warning

Rate limit exceeded

@junyu0312 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 51 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 51 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1ec2afda-0e42-488f-9df6-c9d24f57f7c9

📥 Commits

Reviewing files that changed from the base of the PR and between 4e67fb0 and d117dbd.

📒 Files selected for processing (6)

• crates/vm-core/src/virt.rs
• crates/vm-core/src/virt/hvp.rs
• crates/vm-core/src/virt/kvm.rs
• crates/vm-machine/src/error.rs
• crates/vm-machine/src/vm.rs
• crates/vm-machine/src/vm_builder.rs

📝 Walkthrough

Walkthrough

This PR refactors the vCPU API by removing the Vcpu associated type and accessor methods from the Virt trait, eliminating vCPU storage from Hvp and KvmVirt implementations, adjusting vCPU trait imports across multiple files, and relaxing AArch64Vcpu trait bounds in the bootloader.

Changes

Cohort / File(s)	Summary
vCPU Trait Interface Removal crates/vm-core/src/virt.rs	Removed Vcpu associated type and accessor methods (get_vcpu_mut, get_vcpus, get_vcpus_mut) from the Virt trait definition.
vCPU Implementation Cleanup crates/vm-core/src/virt/hvp.rs, crates/vm-core/src/virt/kvm.rs	Removed type Vcpu associated type declarations and vCPU accessor methods from both Hvp and KvmVirt implementations; eliminated internal vCPU storage in Hvp.
vCPU Trait Import Adjustments crates/vm-core/src/virt/kvm/vcpu/arch/aarch64.rs, crates/vm-core/src/virt/kvm/vcpu/arch/x86_64.rs	Redirected Vcpu trait imports to reflect reorganization of trait location (from crate::virt to crate::arch::vcpu or crate::virt::kvm).
AArch64 Bootloader Constraint Relaxation crates/vm-bootloader/src/boot_loader/arch/aarch64.rs	Removed AArch64Vcpu trait bound from BootLoaderBuilder<V> and BootLoader<V> generic implementations for AArch64BootLoader.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: Refine API for smp #76: Related through concurrent modifications to vCPU/VM trait APIs (modifying Vcpu::run and Virt::run signatures alongside vCPU ownership changes).
• refine: Refine error #83: Related through changes to the AArch64Vcpu trait that directly impact the trait bounds being relaxed in this PR.
• feat: Support smp #77: Related through complementary changes to the Virt trait's Vcpu associated type and AArch64 bootloader trait bounds.

Poem

🐰 The vCPU bonds we once held tight,
Now loosened free, they take their flight,
From trait to trait, the paths align,
A simpler dance, a cleaner line,
The bootloader leaps without its chain! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Refactor hvp' is too vague and generic; it doesn't convey what specific refactoring changes were made or the primary objective of the changeset.	Provide a more specific title that describes the main refactoring objective, such as 'Remove Vcpu trait bounds and accessors from virt implementations' or 'Refactor vCPU management to remove trait-level accessors'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor_hvp

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}