Skip to content

config.yml: remove ref to PR template#17

Merged
yuvipanda merged 1 commit into
jupyterhub:mainfrom
manics:pr-welcome-no-template
Sep 6, 2023
Merged

config.yml: remove ref to PR template#17
yuvipanda merged 1 commit into
jupyterhub:mainfrom
manics:pr-welcome-no-template

Conversation

@manics

@manics manics commented Apr 14, 2023

Copy link
Copy Markdown
Member

This config applies across the jupyterhub org, but not all repos have a PR template

See jupyterhub/zero-to-jupyterhub-k8s#3072 (comment)

Alternatively we could add a PR template .... we discussed this a few years ago #11 but given it's age may need changing.

This config applies across the jupyterhub org, but not all repos have a PR template
@consideRatio

Copy link
Copy Markdown
Member

Seems like an incremental improvement, not merging directly as it was just opened - but if left unmerged the next week without feedback etc I figure it should get merged.

@yuvipanda yuvipanda merged commit 07f97e2 into jupyterhub:main Sep 6, 2023
@welcome

welcome Bot commented Sep 6, 2023

Copy link
Copy Markdown

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@manics manics deleted the pr-welcome-no-template branch September 6, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants