feat(mongodb): allow running as single member replicat set #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is needed to use change streams also - add ulimit config, which can be used to set nubmer of open descritors which mongod is allow to use - fix probe not respecting host\port config (juspay#526)
Contributor
Author
|
it would be good to add more tests, should just just add more processes to nix/services/mongodb_test.nix or add another file? |
Member
|
Haven't thought about different files for tests yet. That would be quite useful when the number of instances of service keeps growing. Moreover, since all these instances define their test in the same "test" process, it can get cluttered quite soon. How about we use ".nix/services/mongodb_myTestName_test.nix"? We could standardise/improve it later when more such test files start appearing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is needed to use change streams
also:
which mongod is allow to use
best to ignore white-space changes when reviewing: https://github.com/juspay/services-flake/pull/528/files?diff=unified&w=1