Skip to content

feat: introduce redis for caching configurations #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushjain17 merged 22 commits into from
Mar 6, 2026
Merged

feat: introduce redis for caching configurations #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cb262a8
fix: make high performance mode a runtime configuration
Datron Nov 18, 2025
8de6284
feat: perform redis reads when getting configs
Datron Nov 19, 2025
cd147ca
feat: introduce writeback methods for redis
Datron Dec 18, 2025
d80b4b2
feat: use redis caches in combined resolve API
Datron Jan 9, 2026
4316989
chore: rebase with main
Datron Feb 9, 2026
846f54f
fix: improve config version fetches
Datron Feb 10, 2026
dcae59b
fix: remove duplicate functions
Datron Feb 10, 2026
1e173bc
fix: update redis caching for experiment APIs
Datron Feb 10, 2026
b64b3b3
feat: add workspace settings caching through redis in middleware
Datron Feb 12, 2026
ffe9908
fix: address first pass comments
Datron Feb 23, 2026
5188e0b
fix: rebase with main
Datron Feb 25, 2026
4669d8d
chore: rebase with main
Datron Mar 2, 2026
21efa6d
fix: address PR comments
Datron Mar 5, 2026
a5f20b1
fix: remove clones on db_pool and redis_pool
Datron Mar 5, 2026
997724f
chore: cleanup files
Datron Mar 5, 2026
a600d57
fix: address 2nd pass of comments
Datron Mar 5, 2026
3e7e610
fix: 3rd pass of comments
Datron Mar 5, 2026
53ed61f
fix: update comments on and simplify `fetch_from_redis_else_writeback`
Datron Mar 5, 2026
efb11dd
fix: change function name
Datron Mar 5, 2026
35cffca
fix: resolving comments
Datron Mar 5, 2026
2bc3a06
fix: remove json! macro
Datron Mar 5, 2026
4527c0e
fix: builds
Datron Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ AUTH_PROVIDER=DISABLED
AUTH_Z_PROVIDER=DISABLED
WORKER_ID=1
# MASTER_ENCRYPTION_KEY - add this for enabling secrets in local
# REDIS_URL="http://localhost:6379"
Copy link
Copy Markdown
Collaborator

@ayushjain17 ayushjain17 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going ahead without tests for redis then ?

Copy link
Copy Markdown
Collaborator Author

@Datron Datron Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I'll setup the build pipeline for this. I haven't added it to github builds

REDIS_POOL_SIZE="10"
REDIS_MAX_ATTEMPTS="10"
REDIS_CONN_TIMEOUT="1000"
# TTL in seconds
REDIS_KEY_TTL=604800

################################################
## Following values are to be set in KMS and not directly in ENV
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci_check_pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ env:
jobs:
formatting:
name: Check formatting
runs-on: anton1
runs-on: codebuild-superposition-${{ github.run_id }}-${{ github.run_attempt }}
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:

test:
name: Testing
runs-on: anton1
runs-on: codebuild-superposition-${{ github.run_id }}-${{ github.run_attempt }}
services:
postgres:
image: public.ecr.aws/docker/library/postgres:15-alpine3.21
Expand Down Expand Up @@ -195,7 +195,7 @@ jobs:

java-build:
name: Java build
runs-on: anton1
runs-on: codebuild-superposition-${{ github.run_id }}-${{ github.run_attempt }}
defaults:
run:
working-directory: clients/java
Expand Down Expand Up @@ -252,7 +252,7 @@ jobs:

provider-tests:
name: Provider Tests
runs-on: anton1
runs-on: codebuild-superposition-${{ github.run_id }}-${{ github.run_attempt }}
strategy:
matrix:
provider:
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions crates/context_aware_config/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ blake3 = { workspace = true }
cac_client = { path = "../cac_client" }
chrono = { workspace = true }
diesel = { workspace = true, features = ["numeric"] }
fred = { workspace = true, optional = true, features = ["metrics"] }
fred = { workspace = true, features = ["metrics"] }
itertools = { workspace = true }
jsonlogic = { workspace = true }
jsonschema = { workspace = true }
Expand All @@ -35,11 +35,9 @@ superposition_types = { workspace = true, features = [
"diesel_derives",
"server",
] }
uuid = { workspace = true }

[features]
disable_db_data_validation = ["superposition_types/disable_db_data_validation"]
high-performance-mode = ["dep:fred"]


[lints]
Expand Down
Loading
Loading