This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fix race condtion that cause corrupted tail of output TS#875
Open
moveman wants to merge 1 commit intojustdan96:masterfrom
Open
Fix race condtion that cause corrupted tail of output TS#875moveman wants to merge 1 commit intojustdan96:masterfrom
moveman wants to merge 1 commit intojustdan96:masterfrom
Conversation
|
Can you provide a sample source file and output: before and after? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found that occasioinally the tail of the TS output is corrupted. After some debugging and guessing, the problem should be caused by this code
This code is not atomic. It is equivalent to this:
Other threads could jump in after the first line and before the second line.
This includes BufferedFileWriter::addWriterData(). When addWriteData() is indeed be called,
the situation will be like this:
writeQueue is inserted a data and is NOT empty; however, m_nothingToExecute is set to true by the final line.
That will cause waitForWriting() to return and then close() is called before the remaining byte is flushed to the output.