Fix cross-path release reproducibility - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first BlackSTAR 1.0.0 publication attempt was correctly blocked by its
independent-build reproducibility gate. Bundled HTSlib embedded the absolute
checkout directory in DWARF metadata, so builds from the Actions checkout and
a detached worktree produced different binaries, SBOMs, checksums, and
archives.
This change:
No alignment, indexing, genome-insert, or output behavior is changed.
Failure evidence
Release workflow run
30124459260stopped before attestation or publication.
The only binary string difference was the HTSlib compilation directory:
/home/runner/work/blackSTAR/blackSTAR/source/htslib/home/runner/work/_temp/source-2/source/htslibThe failed build artifacts were retained by GitHub Actions. No GitHub release
was created.
Fix verification
Commit
cb4b75b6a70722d807a0a8861e67d68b030510f1was built from two cleanworktrees rooted at:
/mnt/datavault/Agentic/STAR/STAR-blackstar-release-repro-fix/tmp/blackstar-repro-fix-source-bEvery release product was byte-identical:
cef54809933da2801934926a7da99072bc8b936876a3d9af01f4a810a95b8737d9078a16e90bee75821fb9ca91a07581aa37a5ecc9fda5edfb9d37edfa645ca8Neither binary contains its original checkout root; HTSlib records the
normalized path
./source/htslib.Release handling
The annotated
v1.0.0tag currently identifies the pre-fixmaincommit, butthere is no
v1.0.0release. After this PR passes and merges, the unpublishedtag will be replaced with an annotated tag on corrected
main, verified, andthe guarded publication workflow will be rerun.