Skip to content

refactor: optimize length calculation for list, text #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justsandip merged 1 commit into from
Mar 28, 2026
Merged

refactor: optimize length calculation for list, text #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions lib/src/types/synk_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ class SynkList {
// used for safe topological replay of existing history.
final Set<ID> _integrated = {};

// Cache for the length of the list (number of non-deleted items).
int _length = 0;

// ── Internals ────────────────────────────────────────────────────────────

void _processItem(Item item) {
Expand Down Expand Up @@ -91,7 +94,10 @@ class SynkList {
if (item.deleted) {
if (item.leftOrigin != null) {
final target = _findById(item.leftOrigin!);
target?.delete();
if (target != null && !target.deleted) {
target.delete();
_length--;
}
}
_integrated.add(item.id);
return;
Expand Down Expand Up @@ -137,6 +143,7 @@ class SynkList {
item.right!.left = item;
}

_length++;
_integrated.add(item.id);
}

Expand Down Expand Up @@ -243,15 +250,7 @@ class SynkList {
}

/// The number of non-deleted elements.
int get length {
var count = 0;
var current = _start;
while (current != null) {
if (!current.deleted) count++;
current = current.right;
}
return count;
}
int get length => _length;

/// Returns all non-deleted values as an ordered [List].
List<dynamic> toList() {
Expand Down
19 changes: 9 additions & 10 deletions lib/src/types/synk_text.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ class SynkText {
// used for safe topological replay of existing history.
final Set<ID> _integrated = {};

// Cache for the length of the sequence (number of non-deleted characters).
int _length = 0;

// ── Internals ────────────────────────────────────────────────────────────

void _processItem(Item item) {
Expand Down Expand Up @@ -92,7 +95,10 @@ class SynkText {
if (item.deleted) {
if (item.leftOrigin != null) {
final target = _findById(item.leftOrigin!);
target?.delete();
if (target != null && !target.deleted) {
target.delete();
_length--;
}
}
_integrated.add(item.id);
return;
Expand Down Expand Up @@ -138,6 +144,7 @@ class SynkText {
item.right!.left = item;
}

_length++;
_integrated.add(item.id);
}

Expand Down Expand Up @@ -251,15 +258,7 @@ class SynkText {
}

/// The number of active (non-deleted) characters.
int get length {
var count = 0;
var current = _start;
while (current != null) {
if (!current.deleted) count++;
current = current.right;
}
return count;
}
int get length => _length;

/// Returns the complete visible text string.
String get text {
Expand Down
Loading