Open
Conversation
This was referenced Apr 4, 2023
6 tasks
Aaron1337men
approved these changes
Jun 14, 2023
|
Nice work 👍 This PR contains the merge of this PR as an open todo. The PR is reviewed and has no conflict. Is there a reason why it's still open? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14
The scaling functionality behaves similarly to Android's scales. However, I can update the algorithm to use cropping if both
maxWidthandmaxHeightare present to match the behavior of iOS.Running example on the web:
thumbnail.mp4
I have tested it with
video_editorpackage:video_editor.mp4
I have updated the plugin to use an endorsed federated plugin. You can find more information on this at https://medium.com/flutter/how-to-write-a-flutter-web-plugin-part-2-afdddb69ece6
As for publishing, here are the steps:
pubspec.yaml. (I will update the PR.)video_thumbnail_platform_interfaceas a new package.video_thumbnail_webas a new package.video_thumbnailpackage.