Adding a Dockerfile and starting publishing node9 runtime#14
Open
rvs wants to merge 1 commit intojvburnes:masterfrom
Open
Adding a Dockerfile and starting publishing node9 runtime#14rvs wants to merge 1 commit intojvburnes:masterfrom
rvs wants to merge 1 commit intojvburnes:masterfrom
Conversation
Signed-off-by: Roman Shaposhnik <rvs@zededa.com>
Contributor
Author
|
Btw, @jvburnes if you're curious how our first test run went -- please take a look here https://github.com/rvs/node9/runs/1619959043 If you like it -- you'll have to add two secrets to your GitHub repo so that action can push to DockerHUB as shown above. Please respond with your public GPG key so I can send those to you privately. |
Contributor
Author
|
Happy New Year @jvburnes! Any thoughts on whether this could be merged (I also still need your DockerHUB ID for the org). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a rough cut of publishing Node9 into Dockerhub under the name node9/runtime. This will happen on every push into the master and will enable us to do things like:
Or, more interestingly, things like:
Note that the usual
docker run -it node9/runtime -hwill work as expected as well and will print help message (and the same applies to all the other command line arguments that one would pass to node9 like-tfor example).