test: verify jyje-add-github-models-provider after 0.1.1 sync (not for landing) - #9
Closed
jyje wants to merge 3 commits into
Closed
test: verify jyje-add-github-models-provider after 0.1.1 sync (not for landing)#9jyje wants to merge 3 commits into
jyje wants to merge 3 commits into
Conversation
Adds github-models as a selectable OpenWiki provider backed by the OpenAI-compatible GitHub Models inference endpoint (https://models.github.ai/inference). Unlike GitHub Copilot, GitHub Models accepts fine-grained personal access tokens (with the "Models" permission) and, in GitHub Actions, the built-in GITHUB_TOKEN with `models: read` job permissions -- no secret required. Since GitHub Actions reserves secret names starting with GITHUB_, the provider config supports an alias env var (GH_MODELS_API_KEY) via a new apiKeyEnvAliases mechanism in ProviderConfig, resolved in loadOpenWikiEnv() through applyProviderEnvAliases(). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GjNFojcfsEnwPRSkhqcxbt
…els-provider Syncs with upstream 0.1.1+ (53 commits, including the engineering- hygiene refactor from langchain-ai#141 and NVIDIA NIM (langchain-ai#42) landing on main since this branch's last sync). Five files conflicted: - src/constants.ts: union of the two independent additions — apiKeyEnvAliases/applyProviderEnvAliases (this branch) alongside authMethod/resolveProviderBaseUrl/isValidBaseUrl (upstream), plus "github-models" and "nvidia" both added to the provider type and SELECTABLE_OPENWIKI_PROVIDERS. - src/env.ts: same union for imports/MANAGED_ENV_KEYS; took upstream's derived CREDENTIAL_DIAGNOSTIC_ENV_KEYS.map(...) over the old manual diagnostics array (github-models flows through automatically). - src/agent/index.ts, src/cli.tsx: took upstream's DEBUG_ENV_KEYS-based formatEnvironmentDebug() and removed the old inline getErrorMessage/sanitizeDiagnosticText block (moved to the new src/diagnostics.ts upstream); dropped the now-unused GITHUB_MODELS_API_KEY_ENV_KEY imports in both files. - src/diagnostics.ts (new upstream file, no history overlap): added GITHUB_MODELS_API_KEY_ENV_KEY to the secret-redaction list, mirroring the NVIDIA_API_KEY_ENV_KEY entry already there. - README.md: kept the GitHub Models section, merged into upstream's rewritten provider intro and section ordering (ChatGPT login, alternative base URLs, retry attempts, NVIDIA NIM). Verified: format:check, lint:check, typecheck, build, and pnpm test (198/198) all pass after resolution. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GjNFojcfsEnwPRSkhqcxbt
Leftover from the merge conflict resolution in the previous commit — the manual key-list arrays that referenced it were replaced by upstream's derived DEBUG_ENV_KEYS/CREDENTIAL_DIAGNOSTIC_ENV_KEYS, so the constant is no longer used directly in these two files. Caught by CI lint (missed locally because the fix was made in the working tree but not re-staged before the merge commit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GjNFojcfsEnwPRSkhqcxbt
Owner
Author
|
Verified — all CI jobs pass on jyje-add-github-models-provider@514d944 (isolated snapshot, after fixing an unused-import lint failure caught by this run and pushed to the working branch separately). Closing without merging; working branch untouched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolated verification only — this branch is a detached snapshot of jyje-add-github-models-provider@c604d7b, not the working branch itself. Confirms the upstream 0.1.1 merge resolution passes CI. Will be closed without merging; the working branch is untouched by this PR.