Latest Version - #161
Open
felicia-b wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently an error with the ammount of points scored for walking on paths:
I start the game with
py scripts/play.py -g Amidaror
py scripts/play.py -g Amidar -m NoEnemiesMazeJust walking across from one side to the other should get 31 Points, but here it gets 37 or 40.
It is correct in the commit that first added scoring for walking on paths, commit ID 4ef9ad5
There, the command I used to start the game is
py scripts/play.py --game \src\jaxatari\games\jax_amidar.py --playThe error happened before the last time I merged to this branch, it is already wrong on the version before this pull request.
To more easily debug there is a line which can be un-commented in versions before the no-emenies version existed, that disables colissions:
# collisions = jnp.zeros_like(collisions, dtype=jnp.bool_) # FOR DEBUGGING OTHER THINGS: remove collisionsYou should be able to push into my forks branch of this pull request