First Submission: Pitfall - #254
Open
omarFarooq21 wants to merge 38 commits into
Open
Conversation
Add a screen-to-layout mapping (ladder presence + tunnel wall side/position) for ~190 of the original 255 screens, based on observed playthrough progression (~191 screens). This is intentionally a partial implementation: remaining screens default to no special layout until we expand coverage.
…xclude pit_type=1). keep lip zone from backdrop.
…awns with improved underground re-entry, and shorten normal jump carry. Add in missing sprites for ladder and logs.
📁 Previous CI results (run #23375594748)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: pitfall ❌This log was automatically created at 2026-03-21 08:15:46 UTC. |
📁 Previous CI results (run #23789661949)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-21 08:23:57 UTC. |
📁 Previous CI results (run #23799598894)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-31 09:17:56 UTC. |
📁 Previous CI results (run #32198416483)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-31 13:29:21 UTC. |
…rry attachment. Fix rope raster using ALE-verified anchor, rows, colors, and canopy priority. Add cobra/croc/fire sprites and align hazards, deaths, and rendering with the ROM.
📁 Previous CI results (run #32210081677)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: pitfall ❌This log was automatically created at 2026-08-18 23:44:47 UTC. |
…7) with shared PF2 playfield/bounds machinery
📁 Previous CI results (run #32235173635)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: pitfall ❌This log was automatically created at 2026-08-19 02:52:46 UTC. |
…bag, silver/gold bar, diamond ring) with persistence
📁 Previous CI results (run #32238144062)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: pitfall ❌This log was automatically created at 2026-08-19 08:58:22 UTC. |
Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: pitfall ❌This log was automatically created at 2026-08-19 09:33:26 UTC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Pitfall environment and added the required observation and image spaces so it works with the current wrappers and compatibility tests.
Main updates: