Repository navigation
feat(heartbeats): send outbound heartbeats to another instance - #123
Merged
Merged
Conversation
Let an instance ping a URL at a fixed interval, typically the /ping URL of a heartbeat on another maintenant instance, so that instance alerts when this one stops. Targets are managed from a new Outgoing tab on the Heartbeats page. Add migration 34 (outbound_heartbeats) on SQLite and PostgreSQL, a background send loop, and CRUD plus send-now endpoints under /api/v1/outbound-heartbeats.
…ses only Outbound targets must use https and are checked with ssrf.ValidateURL when created or updated; sends go through ssrf.NewHTTPClient with private ranges refused, so the feature cannot be used to probe internal services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An instance can watch everything except itself. Pinging a heartbeat on another maintenant instance at a fixed interval lets that instance raise an alert when this one stops.
What
/pingURL of a heartbeat on another instance) pinged at a fixed interval by a background loop./api/v1/outbound-heartbeats.outbound_heartbeats) on SQLite and PostgreSQL.