Repository navigation
fix(ui): keep the header actions visible on narrower screens - #127
Merged
Merged
Conversation
The header's left group could not shrink, and the resource gauges showed from a 1024px viewport regardless of the sidebar, so the feedback link and the alert bell were pushed out of the header and clipped at 1440px. The action group no longer shrinks, the search box does, and the counters and gauges appear on the header's own width (container queries), with higher thresholds when the host selector is shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 1440px the header's left group (search, counters, resource gauges) could
not shrink, and the gauges showed from a 1024px viewport without accounting
for the sidebar. The feedback link and the alert bell were pushed out of the
header and clipped, and focusing the bell scrolled the whole content pane
sideways.
The action group no longer shrinks, the search box can, and the counters and
gauges now appear based on the header's own width (container queries), with
higher thresholds when the host selector is shown.