fix(demo): show outbound heartbeats read-only instead of hiding them - #130
Merged
Merged
Conversation
Register the outbound heartbeat routes in demo mode and keep the page and its nav entry, like agent enrollment: DemoModeGuard refuses every write and the scheduler stays off, so no ping is ever sent. Drop the now unused hideInDemo nav flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In demo mode, outbound heartbeats were the only feature removed from the product: routes unregistered, nav entry hidden, page replaced by an "Unavailable in demo mode" state. Every other feature, such as agent enrollment, stays visible and is simply refused on write.
This aligns outbound heartbeats with that behaviour:
DemoModeGuardrefuses every write with403 DEMO_MODE, which the UI already turns into the demo toast.hideInDemonav flag had no other user and is removed.