Skip to content

fix: graceful handling of gameUI null exception #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaamyashinde merged 1 commit into from
May 23, 2025
Merged

fix: graceful handling of gameUI null exception #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/edu/ntnu/iir/bidata/view/snakesandladders/SnakesAndLaddersMenuUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ private VBox setUpCenterBox() {
* @param gameUI the {@code BorderPane} layout to be used as the root of the new scene
*/
private void createAndSetScene(BorderPane gameUI) {
try {
// SAFETY: Always ensure the root node is not already attached to another scene
if (gameUI.getScene() != null) {
// Detach from previous scene to avoid IllegalArgumentException
Expand All @@ -217,6 +218,9 @@ private void createAndSetScene(BorderPane gameUI) {
getClass().getResource("/style/snakesandladders.css").toExternalForm());
primaryStage.setScene(scene);
primaryStage.show();
} catch (Exception e) {
LOGGER.log(Level.SEVERE, "Game UI was null, but application should not crash.");
}
}

/**
Expand Down