Repository navigation
Bootstrap test: reach the fake Supervisor by IP, and require a real run - #7
Merged
Merged
Conversation
On GitHub's runners the fake Supervisor's network alias did not resolve on the --internal network. The add-on read no options and took its clean-up path in every case, so the genuine install could not be checked, and the attack cases passed their safety checks without the add-on ever reaching the archive. The add-on now finds the fake Supervisor through --add-host, after the server answers. Every case must show the add-on read its options and got a run_token, so a run that did nothing can no longer pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Test add-ons" run on
mainat 626a1ff failed. The add-on was not at fault; the harness was.What happened. On GitHub's runners, the fake Supervisor's network alias did not resolve on the
--internalnetwork. The add-on loggedCould not resolve host: supervisor, read no options, and correctly took its clean-up-only path in every case. So the genuine install was never exercised. The refusal cases also passed their safety checks without ever reaching the archive. Locally (Docker 29.6.2) the alias resolved, which is why that run showed 31/31.Fix, test only:
--add-host, once the server answers.run_token, so a run that did nothing cannot pass again.Evidence:
The published images were checked separately.
amd64-dartec-bootstrap:0.3.0from ghcr (sha256:0e88b79e…), run against the fake Supervisor, installed HACS 2.0.5, wrote the entry, and stopped and restarted Core.This only touches
tests/, sobuild.ymldoes not run and no image is rebuilt or re-pushed.🤖 Generated with Claude Code