Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track app release rows through an explicit pending-to-in-progress transition before terminal apply outcomes.
What Changed
pendingin_progressonly when backend work beginsWhy
Phase 3 rollout-state work needs release lifecycle state to reflect execution timing instead of treating row creation as work already in progress.
Validation
YOQ_SKIP_SLOW_TESTS=1 zig build test -Doptimize=ReleaseSafe -Dtest-filter='execute marks completed releases on backend success'YOQ_SKIP_SLOW_TESTS=1 zig build test -Doptimize=ReleaseSafe -Dtest-filter='recordAppReleaseStart stores app-scoped deployment metadata'YOQ_SKIP_SLOW_TESTS=1 zig build test -Doptimize=ReleaseSafe -Dtest-filter='app apply route preserves partially failed release metadata across reads'YOQ_SKIP_SLOW_TESTS=1 zig build test -Doptimize=ReleaseSafe -Dtest-filter='execute marks failed releases on backend error'YOQ_SKIP_SLOW_TESTS=1 zig build test -Doptimize=ReleaseSafe -Dtest-filter='app apply then rollback routes preserve release transition metadata'git diff --check