Publish the Kubernetes credential provider image in releases - #44
Merged
Merged
Conversation
Build the nested provider package with the release images and publish it under the kubernetes-secrets basename expected by the Helm chart. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart now always deploys the Kubernetes credential provider, but the release workflow omitted its image. Add
cmd/credential-provider/kubernetes-secretsto the existing build loop and publish it asghcr.io/<owner>/<repo>/kubernetes-secrets:<tag>, matching the chart and installer. It receives the same release tags and Linux amd64/arm64 platforms as the other components.Validation: both platform images build successfully with
ko build --push=false; a dry run of the workflow step verifies all eight image paths, tags, and platforms;env -u NO_COLOR make verifypasses.