Skip to content

Conversation

@qasmi
Copy link
Contributor

@qasmi qasmi commented Aug 8, 2025

#22

This comment was marked as outdated.

@qasmi qasmi requested review from EItanya and dimetron as code owners August 13, 2025 13:30
@dimetron dimetron requested review from Copilot and removed request for EItanya and dimetron August 14, 2025 19:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Kubernetes pod scheduling support by introducing nodeSelector, tolerations, affinity, and topologySpreadConstraints configuration options to the Helm chart. This enables users to control where their pods are scheduled based on node characteristics and constraints.

  • Added four new scheduling configuration options to values.yaml with appropriate defaults
  • Updated deployment template to conditionally include these scheduling configurations
  • Enhanced topologySpreadConstraints with automatic labelSelector injection when not provided

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
helm/kagent-tools/values.yaml Adds new scheduling configuration fields with comments and example values
helm/kagent-tools/templates/deployment.yaml Implements conditional rendering of scheduling configurations in the pod spec

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@EItanya
Copy link
Contributor

EItanya commented Aug 14, 2025

@dimetron, this PR is making me realize that we need helm unit tests

@qasmi
Copy link
Contributor Author

qasmi commented Aug 15, 2025

@EItanya I will add the unit tests

Copy link
Contributor

@EItanya EItanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks so much for adding unit tests :)

Signed-off-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local>
@EItanya EItanya merged commit 35ac04a into kagent-dev:main Oct 21, 2025
5 checks passed
GTRekter pushed a commit to GTRekter/tools that referenced this pull request Dec 4, 2025
Signed-off-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local>
Co-authored-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local>
Signed-off-by: Ivan Porta <porta.ivan@outlook.com>
GTRekter pushed a commit to GTRekter/tools that referenced this pull request Dec 4, 2025
Signed-off-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local>
Co-authored-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local>
Signed-off-by: Ivan Porta <porta.ivan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants