-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add support for nodeSelector and tolerations #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Kubernetes pod scheduling support by introducing nodeSelector, tolerations, affinity, and topologySpreadConstraints configuration options to the Helm chart. This enables users to control where their pods are scheduled based on node characteristics and constraints.
- Added four new scheduling configuration options to values.yaml with appropriate defaults
- Updated deployment template to conditionally include these scheduling configurations
- Enhanced topologySpreadConstraints with automatic labelSelector injection when not provided
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| helm/kagent-tools/values.yaml | Adds new scheduling configuration fields with comments and example values |
| helm/kagent-tools/templates/deployment.yaml | Implements conditional rendering of scheduling configurations in the pod spec |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
@dimetron, this PR is making me realize that we need helm unit tests |
|
@EItanya I will add the unit tests |
EItanya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks so much for adding unit tests :)
Signed-off-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local>
Signed-off-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local> Co-authored-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local> Signed-off-by: Ivan Porta <porta.ivan@outlook.com>
Signed-off-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local> Co-authored-by: Sara Qasmi <saraqasmi@Saras-MacBook-Pro.local> Signed-off-by: Ivan Porta <porta.ivan@outlook.com>
#22