feat: add typed discriminated union models for audit event attributes#31
Merged
Conversation
Owner
kaincenteno
commented
May 18, 2026
kaincenteno
commented
- Replaces the flat AuditEvent.Attributes model (with _warn_extra warning validator) with a fully-typed Pydantic discriminated union keyed on eventDataPropertyKey
- Adds AuditEventCommonAttributes base class with all 11 shared fields
- Adds 33 concrete *Attributes subclasses — one per audit event type — each with a Literal discriminator and its corresponding typed payload field
- Adds 33 inner event data models (AuditEventAccountDeleted, -AuditEventDeviceRemovedFromOrg, etc.) covering all payload shapes documented by the Apple Business API, including the AuditEventAccountRoleLocation sub-object
- Removes unused logging import and model_validator now that _warn_extra is gone
- Replaces the flat AuditEvent.Attributes model (with _warn_extra warning validator) with a fully-typed Pydantic discriminated union keyed on eventDataPropertyKey - Adds AuditEventCommonAttributes base class with all 11 shared fields - Adds 33 concrete *Attributes subclasses — one per audit event type — each with a Literal discriminator and its corresponding typed payload field - Adds 33 inner event data models (AuditEventAccountDeleted, -AuditEventDeviceRemovedFromOrg, etc.) covering all payload shapes documented by the Apple Business API, including the AuditEventAccountRoleLocation sub-object - Removes unused logging import and model_validator now that _warn_extra is gone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.