Repository navigation
chore: adopt the Kaiten licensing pack and the DCO - #3
Open
Alex (Alexkuva) wants to merge 2 commits into
Open
Alex (Alexkuva) wants to merge 2 commits into
Alex (Alexkuva) wants to merge 2 commits into
Conversation
The licensing and contribution files every Kaiten SDK ships, from the pack in kaitencloud/brain (licence/sdk), as sdk-python, sdk-js and cli already do: - LICENSE is the apache.org text, byte for byte. The previous one reworded section 9, which SPDX tools do not recognise, nor pkg.go.dev, which reads the file to decide whether it may show the documentation; - NOTICE, DCO.md, CONTRIBUTING.md and SECURITY.md, for the Go SDK; - in .github: CODEOWNERS (* @kaitencloud/engineering), so the ruleset's code-owner rule has owners to ask; the pull request template; the DCO workflow, unchanged from the pack; - every Go file opens with the SPDX header, the generated clients too: task generate and task generate:platform write it, and TestLicenseHeaders fails on a file without it; - the README's license section, and the sign-off in its contributing section. Signed-off-by: Alexandre Bergere <alexandre.bergere@kaiten.sh>
fuzcap
approved these changes
Oct 8, 2026
fuzcap
enabled auto-merge (squash)
October 8, 2026 14:10
fuzcap
disabled auto-merge
October 8, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The licensing and contribution files every Kaiten SDK ships, from the pack in
kaitencloud/brain(licence/sdk), assdk-python,sdk-jsandclialready do. Steps 1, 2, 3 and the first half of 5 of the pack's README.LICENSENOTICEKaiten SDK for Go/Copyright 2026 KAITEN INCDCO.md,CONTRIBUTING.md,SECURITY.md.github/CODEOWNERS* @kaitencloud/engineering: the ruleset already requires code-owner review, and until now had no owner to ask.github/PULL_REQUEST_TEMPLATE.md.github/workflows/dco.ymlmain(pull_request_target), so it starts judging pull requests once this is merged.gofiles// Copyright 2026 KAITEN INCand// SPDX-License-Identifier: Apache-2.0, followed by a blank line so the header stays out of the package docTaskfile.ymltask generateandtask generate:platformwrite the header on the generated clients: oapi-codegen has no option for itheaders_test.goTestLicenseHeadersfails on any Go file without the header, generated ones includedREADME.mdGo has no package metadata to declare: the module's
LICENSEis the declaration.Order
Lint, Build & Testcheck, and the ruleset blocks it. Re-run its checks once ci: report lint, build and test as separate checks #2 is onmain.require_dco = trueforsdk-goinkaitencloud/infra-scm, which addsDCOto the ruleset;sdk-python,sdk-jsandcli, not here.Checked
go vet,go buildandgo test -race -shuffle=on -cover ./....golangci-lintv2.12.2: 0 issues, and its formatters leave the tree unchanged.go mod tidyleavesgo.modandgo.sumunchanged.TestLicenseHeadersfails when a file loses its header.license-headertask, run with Task 3.51 on a generated file.LICENSE,DCO.md,SECURITY.md,CODEOWNERS, the template anddco.ymlare byte-identical to the pack.🤖 Generated with Claude Code · ✅ Tested and approved by Alex (@Alexkuva), maintainer