Repository navigation
ci: enforce the DCO with a workflow the repository owns - #1
Merged
Merged
Conversation
.github/dco.yml configured the third-party DCO app, which is no longer installed: no check verified sign-offs on pull requests any more. .github/workflows/dco.yml takes its place. It checks that every commit of a pull request carries a Signed-off-by trailer naming its author, skipping merge commits and bot accounts, and fails with the SHA of each commit that does not. It runs as it is on main (pull_request_target), so a pull request cannot edit the check that judges it, and it never checks out the pull request's code: it reads commit metadata from the API. Unlike the app, it has no button that sets the check to pass. CONTRIBUTING.md's DCO passage follows: -s versus -S, the DCO check as the final word, and git rebase --signoff for several commits, instead of the app's remediation instructions. The workflow is the one the Kaiten licensing pack ships to every repository, unchanged. Signed-off-by: Alexandre Bergere <alexandre.bergere@kaiten.sh>
fuzcap
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforces the DCO again, with a workflow this repository owns.
.github/dco.ymlconfigured the third-party DCO app, which is no longer installed: nothing hasverified sign-offs on pull requests since.
.github/workflows/dco.ymlchecks that every commit of a pull request carries aSigned-off-bytrailer naming its author, skipping merge commits and bot accounts — Dependabotincluded —, and fails with the SHA of each commit that does not. It runs as it is on
main(
pull_request_target), so a pull request cannot edit the check that judges it, and it neverchecks out the pull request's code. Unlike the app, it has no button that sets the check to
pass.
.github/dco.ymlis deleted.CONTRIBUTING.md: the DCO passage now explains-sversus-S, names theDCOcheck asthe final word, and fixes several commits with
git rebase --signoff origin/main, instead ofthe app's remediation instructions.
It is the workflow the Kaiten licensing pack ships to every repository, unchanged;
sdk-pythonruns it already.
After merging: the workflow runs from
main, so it starts with the next pull request. Thenadd
DCOto thedefault-branchruleset's required checks, with GitHub Actions as its source.🤖 Generated with Claude Code · ✅ Tested and approved by Alex (@Alexkuva), maintainer