⚡ Bolt: Optimize scrollTopBtn scroll event listener#121
Conversation
💡 What: Added state caching (`isScrollBtnVisible`) and `{ passive: true }` to the `scrollTopBtn` scroll event listener in `src/scripts/script.js`.
🎯 Why: Previously, `classList.add` or `classList.remove` was called on every single frame during scroll, causing unnecessary DOM API overhead. Adding `{ passive: true }` prevents the listener from blocking the main thread, ensuring smoother scrolling.
📊 Impact: Eliminates redundant DOM operations during scrolling and improves scroll performance (60fps steady).
🔬 Measurement: Use Chrome DevTools Performance tab to profile scrolling and verify that the `scroll` event handler duration is minimal and DOM updates occur only when the button crosses the visibility threshold (300px).
Co-authored-by: kaitoartz <56949089+kaitoartz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added state caching (
isScrollBtnVisible) and{ passive: true }to thescrollTopBtnscroll event listener insrc/scripts/script.js.🎯 Why: Previously,
classList.addorclassList.removewas called on every single frame during scroll, causing unnecessary DOM API overhead. Adding{ passive: true }prevents the listener from blocking the main thread, ensuring smoother scrolling.📊 Impact: Eliminates redundant DOM operations during scrolling and improves scroll performance (60fps steady).
🔬 Measurement: Use Chrome DevTools Performance tab to profile scrolling and verify that the
scrollevent handler duration is minimal and DOM updates occur only when the button crosses the visibility threshold (300px).PR created automatically by Jules for task 13949602349681261349 started by @kaitoartz