⚡ Bolt: [performance improvement] Prevent GC allocation and unnecessary DOM reflows in scroll event#127
Conversation
…ry DOM reflows in scroll event 💡 What: Replaced `.forEach()` with a `for` loop and added dirty checking for `.classList` updates in the scroll event listener's requestAnimationFrame. 🎯 Why: `.forEach()` creates a new closure every frame, causing GC thrashing. Unconditional `.classList.remove()` and `.add()` can trigger unnecessary DOM mutation events even if the class is already set/removed. 📊 Impact: Eliminates GC allocation per frame and reduces redundant DOM operations. 🔬 Measurement: Use Performance profiling tool in browser to monitor Garbage Collection pressure and DOM mutations while scrolling. Co-authored-by: kaitoartz <56949089+kaitoartz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced
.forEach()with aforloop and added dirty checking for.classListupdates in the scroll event listener's requestAnimationFrame.🎯 Why:
.forEach()creates a new closure every frame, causing GC thrashing. Unconditional.classList.remove()and.add()can trigger unnecessary DOM mutation events even if the class is already set/removed.📊 Impact: Eliminates GC allocation per frame and reduces redundant DOM operations.
🔬 Measurement: Use Performance profiling tool in browser to monitor Garbage Collection pressure and DOM mutations while scrolling.
PR created automatically by Jules for task 15595789386493481779 started by @kaitoartz