Skip to content

⚡ Bolt: optimize scroll nav class mutations#133

Open
kaitoartz wants to merge 1 commit into
mainfrom
bolt-scroll-dirty-check-4203594539398008611
Open

⚡ Bolt: optimize scroll nav class mutations#133
kaitoartz wants to merge 1 commit into
mainfrom
bolt-scroll-dirty-check-4203594539398008611

Conversation

@kaitoartz

Copy link
Copy Markdown
Owner

💡 What: Added a dirty check before updating nav-active classes.
🎯 Why: Unconditionally removing and adding classes on every frame forces the browser to evaluate style changes, causing unnecessary layout thrashing.
📊 Impact: Eliminates redundant DOM mutations when the active section hasn't changed, freeing up main thread CPU time during scroll.
🔬 Measurement: Verify scroll framerate and check for fewer layout recalculations in Chrome DevTools Performance tab.


PR created automatically by Jules for task 4203594539398008611 started by @kaitoartz

Added a dirty check before mutating `nav-active` classes inside the scroll event listener to prevent unnecessary style recalculations and layout thrashing.

Co-authored-by: kaitoartz <56949089+kaitoartz@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant