kaizen: align org-monitor docs and dogfood scheduler configs (#43)#46
Conversation
📝 WalkthroughWalkthroughUpdated ChangesScheduler.jobs Contract Alignment
Sequence Diagram(s)(No sequence diagram: this PR documents a configuration schema change and applies a homogeneous migration pattern across five config files without introducing new inter-component interactions or control flow.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eeb9eaecf9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/org-monitor.md`:
- Around line 22-39: The monitor documentation instructs repositories to use the
new scheduler.jobs model, but the five dogfood-sync target configurations under
.github/dogfood-sync/targets/ (for builder-agent, verifier, kaizen-loop,
coderabbit, and renovate-config) still use the old deprecated scheduler.nightly,
scheduler.afternoon, and scheduler.poll fields. This causes the monitor to flag
these targets as non-compliant with its own documented requirements. Update all
five target config files under
.github/dogfood-sync/targets/{repo}/.kaizen/config.yml to replace the old
scheduler fields with the new scheduler.jobs model using interval-type jobs with
appropriate schedule settings (such as everyHours and anchorTime), matching the
pattern shown in the documentation example, so the organization enforces the
pattern it expects repositories to follow.
- Around line 22-39: The documentation in lines 22-39 describes a new scheduler
contract using `scheduler.jobs` with repository-owned job names and a schema
with `type: interval`, `everyHours`, and `anchorTime` properties. However, the
actual dogfood-sync configuration in
`.github/dogfood-sync/targets/kaizen-loop/.kaizen/config.yml` still uses the old
incompatible fixed-field format with `nightly`, `afternoon`, and `poll` fields
that have `enabled` and `time` properties. Either update the docs to clearly
indicate this is an aspirational future state not yet implemented, or update the
actual dogfood-sync target configuration file to match the new schema described
in the documentation so that the monitor contract and the distributed config are
aligned and compatible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: kaizen-agents-org/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7a066705-3b11-4f75-8ddc-d1085b407651
📒 Files selected for processing (1)
docs/org-monitor.md
|
PR Guardian final status:
This PR is mergeable. I did not merge it. |
Closes #43
Summary
docs/org-monitor.mdto describe the currentscheduler.jobsmodel instead of fixednightly/afternoon/pollscheduler fields..kaizen/config.ymlfiles to the samescheduler.jobsmodel so the org monitor contract does not conflict with configs distributed by daily dogfood sync.Verification
ruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "ok #{f}" }' .github/dogfood-sync/targets/*/.kaizen/config.yml .kaizen/config.ymlruby -ryaml -e 'ARGV.each { |f| scheduler = YAML.load_file(f).fetch("scheduler"); raise "old scheduler keys in #{f}" if scheduler.key?("nightly") || scheduler.key?("afternoon") || scheduler.key?("poll"); jobs = scheduler.fetch("jobs"); %w[maintenance maintenance-followup issue-watch].each { |job| jobs.fetch(job) }; puts "jobs ok #{f}" }' .github/dogfood-sync/targets/*/.kaizen/config.ymlrg -n "^ (nightly|afternoon|poll):" .github/dogfood-sync/targets .kaizen/config.yml docs/org-monitor.mdreturned no matches.test -f docs/README.md && test -f docs/issue-to-pr-mvp.md && test -f profile/README.mdtest -f skills/gh-link-issue-pr/SKILL.md && test -f skills/kaizen-bug-router/SKILL.md && test -f skills/pr-guardian/SKILL.mdReview disposition
75b8bfaaddresses that feedback by aligning all five managed target configs withscheduler.jobs.