Skip to content

kaizen: align org-monitor docs and dogfood scheduler configs (#43)#46

Merged
s-hiraoku merged 2 commits into
mainfrom
kaizen/issue-43-monitor-align-org-monitor-scheduler-docs
Jun 23, 2026
Merged

kaizen: align org-monitor docs and dogfood scheduler configs (#43)#46
s-hiraoku merged 2 commits into
mainfrom
kaizen/issue-43-monitor-align-org-monitor-scheduler-docs

Conversation

@s-hiraoku

@s-hiraoku s-hiraoku commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Closes #43

Summary

  • Updated docs/org-monitor.md to describe the current scheduler.jobs model instead of fixed nightly/afternoon/poll scheduler fields.
  • Migrated the five managed dogfood-sync target .kaizen/config.yml files to the same scheduler.jobs model so the org monitor contract does not conflict with configs distributed by daily dogfood sync.
  • Preserved each target repo's existing staggered maintenance/follow-up times and disabled watch interval while changing only the scheduler schema.

Verification

  • ruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "ok #{f}" }' .github/dogfood-sync/targets/*/.kaizen/config.yml .kaizen/config.yml
  • ruby -ryaml -e 'ARGV.each { |f| scheduler = YAML.load_file(f).fetch("scheduler"); raise "old scheduler keys in #{f}" if scheduler.key?("nightly") || scheduler.key?("afternoon") || scheduler.key?("poll"); jobs = scheduler.fetch("jobs"); %w[maintenance maintenance-followup issue-watch].each { |job| jobs.fetch(job) }; puts "jobs ok #{f}" }' .github/dogfood-sync/targets/*/.kaizen/config.yml
  • rg -n "^ (nightly|afternoon|poll):" .github/dogfood-sync/targets .kaizen/config.yml docs/org-monitor.md returned no matches.
  • test -f docs/README.md && test -f docs/issue-to-pr-mvp.md && test -f profile/README.md
  • test -f skills/gh-link-issue-pr/SKILL.md && test -f skills/kaizen-bug-router/SKILL.md && test -f skills/pr-guardian/SKILL.md

Review disposition

  • CodeRabbit and Codex inline feedback identified that the new org-monitor docs would conflict with the managed dogfood-sync target configs unless those configs were migrated too.
  • Commit 75b8bfa addresses that feedback by aligning all five managed target configs with scheduler.jobs.
  • The config migrations are included in this PR because they are necessary to keep the issue [monitor] Align org monitor scheduler docs #43 documentation change accurate for the organization source of truth.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated docs/org-monitor.md to document the scheduler.jobs configuration model and added a validation check for config alignment. Simultaneously migrated five dogfood target .kaizen/config.yml files (builder-agent, coderabbit, kaizen-loop, renovate-config, verifier) from legacy nightly/afternoon/poll scheduler fields to the new scheduler.jobs structure with named maintenance and issue-watch jobs.

Changes

Scheduler.jobs Contract Alignment

Layer / File(s) Summary
Scheduler contract documentation and validation check
docs/org-monitor.md
Introduces a "Local Kaizen Loop Scheduler" section explaining how repositories define jobs under scheduler.jobs in .kaizen/config.yml, clarifying that job names are repository-owned, and schedule staggering comes from per-job schedule settings (with an interval-job example). Adds a "What It Checks" bullet to verify that scheduler docs and configs use the current scheduler.jobs model instead of stale fixed job fields.
Dogfood target scheduler.jobs migrations
.github/dogfood-sync/targets/builder-agent/.kaizen/config.yml, .github/dogfood-sync/targets/coderabbit/.kaizen/config.yml, .github/dogfood-sync/targets/kaizen-loop/.kaizen/config.yml, .github/dogfood-sync/targets/renovate-config/.kaizen/config.yml, .github/dogfood-sync/targets/verifier/.kaizen/config.yml
Replaces legacy scheduler.nightly, scheduler.afternoon, and scheduler.poll fields with a new scheduler.jobs map structure. Each target now defines a maintenance job (daily at staggered times with lateStartGuard: true), a maintenance-followup job (daily at staggered times with lateStartGuard: false), and an issue-watch job (disabled; 5-minute interval; run.mode: watch; skipIfRunning: true).

Sequence Diagram(s)

(No sequence diagram: this PR documents a configuration schema change and applies a homogeneous migration pattern across five config files without introducing new inter-component interactions or control flow.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related issues

Possibly related PRs

  • kaizen-agents-org/.github#11: Directly modifies the same docs/org-monitor.md file; this PR extends the document with the scheduler.jobs section.
  • kaizen-agents-org/.github#41: Migrates .kaizen/config.yml files to scheduler.jobs entries, directly aligned with the scheduler.jobs contract this PR documents and validates.
  • kaizen-agents-org/kaizen-loop#65: Updates kaizen-loop scheduler documentation and CLI spec around the scheduler.jobs-based model, which is the contract this PR documents in org-monitor.md.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes refactoring of five .kaizen/config.yml files across multiple targets (builder-agent, coderabbit, kaizen-loop, renovate-config, verifier), which substantially exceeds the scope of issue #43, which requests only documentation updates. Either confirm these config changes are part of the documented scope with additional issue references, or move the five config.yml refactorings to a separate PR focused on scheduler migration.
Linked Issues check ❓ Inconclusive The PR updates docs/org-monitor.md with scheduler.jobs documentation but also refactors five .kaizen/config.yml files. The documentation change directly satisfies issue #43's request to align documentation with current scheduler.jobs model. However, the config refactoring appears beyond the stated issue scope. Clarify whether the five config.yml refactorings are required by issue #43 or represent additional out-of-scope changes that should be addressed in separate PRs.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: aligning org-monitor documentation and dogfood scheduler configs to use the current scheduler.jobs model, which is the core objective across all modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kaizen/issue-43-monitor-align-org-monitor-scheduler-docs

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eeb9eaecf9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/org-monitor.md

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/org-monitor.md`:
- Around line 22-39: The monitor documentation instructs repositories to use the
new scheduler.jobs model, but the five dogfood-sync target configurations under
.github/dogfood-sync/targets/ (for builder-agent, verifier, kaizen-loop,
coderabbit, and renovate-config) still use the old deprecated scheduler.nightly,
scheduler.afternoon, and scheduler.poll fields. This causes the monitor to flag
these targets as non-compliant with its own documented requirements. Update all
five target config files under
.github/dogfood-sync/targets/{repo}/.kaizen/config.yml to replace the old
scheduler fields with the new scheduler.jobs model using interval-type jobs with
appropriate schedule settings (such as everyHours and anchorTime), matching the
pattern shown in the documentation example, so the organization enforces the
pattern it expects repositories to follow.
- Around line 22-39: The documentation in lines 22-39 describes a new scheduler
contract using `scheduler.jobs` with repository-owned job names and a schema
with `type: interval`, `everyHours`, and `anchorTime` properties. However, the
actual dogfood-sync configuration in
`.github/dogfood-sync/targets/kaizen-loop/.kaizen/config.yml` still uses the old
incompatible fixed-field format with `nightly`, `afternoon`, and `poll` fields
that have `enabled` and `time` properties. Either update the docs to clearly
indicate this is an aspirational future state not yet implemented, or update the
actual dogfood-sync target configuration file to match the new schema described
in the documentation so that the monitor contract and the distributed config are
aligned and compatible.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: kaizen-agents-org/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7a066705-3b11-4f75-8ddc-d1085b407651

📥 Commits

Reviewing files that changed from the base of the PR and between af4466b and eeb9eae.

📒 Files selected for processing (1)
  • docs/org-monitor.md

Comment thread docs/org-monitor.md
@s-hiraoku s-hiraoku changed the title kaizen: org-monitor文書に現行のscheduler.jobsモデルを追記しました。 (#43) kaizen: align org-monitor docs and dogfood scheduler configs (#43) Jun 23, 2026
@s-hiraoku

Copy link
Copy Markdown
Contributor Author

PR Guardian final status:

  • Mergeability: mergeStateStatus is CLEAN; reviewDecision is APPROVED; PR is open and not draft.
  • Checks: CodeRabbit is passing (Review completed). No GitHub Actions workflow runs exist for this branch/head SHA, so there was no run ID available for gh run watch --exit-status.
  • Fixes pushed: 75b8bfa (Align dogfood scheduler configs with jobs model) migrated all five managed dogfood-sync target .kaizen/config.yml files to scheduler.jobs while preserving existing staggered times and disabled watch interval.
  • Feedback addressed: replied to both unresolved actionable review threads, resolved both threads, and CodeRabbit confirmed the concerns were addressed. Final paginated GraphQL read returned hasNextPage=false for review threads, PR comments, and reviews; no unresolved actionable inline feedback remains.
  • Metadata update: PR title/body now explicitly include the dogfood scheduler config migrations, addressing the non-blocking pre-merge scope/title warnings in the CodeRabbit summary.
  • Unresolved/skipped feedback: none actionable remains. Remaining blockers: none.

This PR is mergeable. I did not merge it.

@s-hiraoku s-hiraoku merged commit 57daf2c into main Jun 23, 2026
1 check passed
@s-hiraoku s-hiraoku deleted the kaizen/issue-43-monitor-align-org-monitor-scheduler-docs branch June 25, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[monitor] Align org monitor scheduler docs

1 participant