kaizen: coderabbit / kaizen-loop の dogfood scheduler 設定が current main と一致することを確認しました。 (#44)#53
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: kaizen-agents-org/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe contract-check script now validates scheduler configs for the ChangesScheduler contract validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c2c1d7aec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/check-daily-dogfood-sync-contract.sh`:
- Around line 169-177: The contract check in
check-daily-dogfood-sync-contract.sh only verifies that keys like scheduler,
jobs, maintenance, maintenance-followup, and issue-watch exist somewhere in the
config, so malformed YAML can still pass. Tighten the validation in the repo
loop by checking the actual nesting under the config structure in config.yml
(for example, ensuring jobs and its children are under scheduler and the other
blocks are at the expected indentation/path), using the existing grep-based
guard around the scheduler/jobs checks so the script fails when hierarchy is
wrong even if the key names are present.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: kaizen-agents-org/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 98a1501e-8549-4e80-9e41-c635f16d0a08
📒 Files selected for processing (1)
scripts/check-daily-dogfood-sync-contract.sh
There was a problem hiding this comment.
♻️ Duplicate comments (1)
scripts/check-daily-dogfood-sync-contract.sh (1)
171-175: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winValidate the scheduler hierarchy, not just the indented key names.
These five
grepcalls still pass when the same lines appear in unrelated blocks with matching indentation, so the regression test can miss a malformed config that does not actually definescheduler.jobs.{maintenance,maintenance-followup,issue-watch}as one nested structure. Tighten this to verify the contiguous hierarchy in a single pass.Suggested tightening
for repo in coderabbit kaizen-loop; do config=".github/dogfood-sync/targets/${repo}/.kaizen/config.yml" - grep -q "^scheduler:" "${config}" - grep -q "^ jobs:" "${config}" - grep -q "^ maintenance:" "${config}" - grep -q "^ maintenance-followup:" "${config}" - grep -q "^ issue-watch:" "${config}" + awk ' + /^scheduler:$/ { in_scheduler=1; next } + in_scheduler && /^ jobs:$/ { in_jobs=1; next } + in_scheduler && !/^ / { in_scheduler=0 } + in_jobs && /^ maintenance:$/ { maintenance=1; next } + in_jobs && /^ maintenance-followup:$/ { followup=1; next } + in_jobs && /^ issue-watch:$/ { issue_watch=1; next } + in_jobs && /^ [^ ]/ { in_jobs=0 } + END { exit(in_scheduler && in_jobs && maintenance && followup && issue_watch ? 0 : 1) } + ' "${config}" if grep -Eq "^[[:space:]]{2}(nightly|afternoon|poll):" "${config}"; then echo "${repo} dogfood scheduler config must use scheduler.jobs, not legacy scheduler keys" >&2 exit 1 fi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/check-daily-dogfood-sync-contract.sh` around lines 171 - 175, The scheduler check in the shell script is only matching individual indented keys, so it can pass even when the hierarchy is broken. Update the validation around the existing `grep` checks to verify the full contiguous `scheduler.jobs` nesting in one pass, using a single pattern or block-aware match that ensures `scheduler`, `jobs`, and the `maintenance`, `maintenance-followup`, and `issue-watch` entries all belong to the same structure.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@scripts/check-daily-dogfood-sync-contract.sh`:
- Around line 171-175: The scheduler check in the shell script is only matching
individual indented keys, so it can pass even when the hierarchy is broken.
Update the validation around the existing `grep` checks to verify the full
contiguous `scheduler.jobs` nesting in one pass, using a single pattern or
block-aware match that ensures `scheduler`, `jobs`, and the `maintenance`,
`maintenance-followup`, and `issue-watch` entries all belong to the same
structure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: kaizen-agents-org/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 60f3540c-c20a-4b88-b5ac-1be933965a35
📒 Files selected for processing (1)
scripts/check-daily-dogfood-sync-contract.sh
|
Addressed CodeRabbit duplicate review feedback from the 9fdf8d1 review in 497fe58. The scheduler contract check now uses a single block-aware awk pass so |
|
PR Guardian final status
|
s-hiraoku
deleted the
kaizen/issue-44-monitor-align-dogfood-manifest-scheduler-configs
branch
1 participant
Closes #44
Summary
coderabbit / kaizen-loop の dogfood scheduler 設定が current main と一致することを確認しました。
legacy scheduler キーへの再発を防ぐ回帰チェックを追加しました。
指定メッセージでローカルコミットを作成済みです。
Builder notes
Commit: 1c2c1d7 kaizen: align dogfood scheduler configs (#44). Protected path changes: none. Verification passed: bash scripts/check-daily-dogfood-sync-contract.sh; bash scripts/test-sync-daily-dogfood.sh; specified test -f command; direct diff against coderabbit/main and kaizen-loop/main configs. gh/workflow/PR operations were not run per constraint.
Verification
test -f docs/README.md && test -f docs/issue-to-pr-mvp.md && test -f profile/README.mdtest -f skills/gh-link-issue-pr/SKILL.md && test -f skills/kaizen-bug-router/SKILL.md && test -f skills/pr-guardian/SKILL.mdKaizen risk policy
Verifier cleared PR: Open PR with 0 should_fix item(s); risk is low.
Changed files: 1
Changed lines: 16
Summary by CodeRabbit