test(core): cover the /proc and /sys readers with shimforge - #14
Open
tanglearncode wants to merge 1 commit into
Open
tanglearncode wants to merge 1 commit into
tanglearncode wants to merge 1 commit into
Conversation
Add 15 tests for hardware.rs and system.rs using shimforge to mock fs::read_to_string and Command::output, so the RISC-V-only reading code can run on any machine. shimforge is dev-only and scoped to x86-64/ARM64, pinned at 0.1.2 (MIT).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to see if you'd like to increase the code coverage by using my new project shimforge. It appears can cover the business logic of the code in
hardware.rsandsystem.rsUses shimforge to mock
fs::read_to_stringandCommand::outputper-thread, so the 15 new tests run on any machine, no fixtures on disk, no uname process.shimforge only supports x86-64/ARM64, so it's a dev-dependency scoped to those targets to cover the business logic of the production code. On RISC-V the crate still builds and everything else still runs but these 15 tests are skipped.