Skip to content

Fixed build-command to use posix-paths for docker#40

Merged
kalhauge merged 8 commits into
mainfrom
fix-buildcmd
Nov 18, 2025
Merged

Fixed build-command to use posix-paths for docker#40
kalhauge merged 8 commits into
mainfrom
fix-buildcmd

Conversation

@BilboBackend

Copy link
Copy Markdown
Collaborator

No description provided.

@kalhauge kalhauge left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite there yet :) Please address the comments.

Comment thread jpamb/cli.py Outdated
Comment thread jpamb/cli.py Outdated
Comment thread jpamb/cli.py Outdated
Comment thread jpamb/cli.py Outdated
Comment thread jpamb/cli.py Outdated
Comment thread test/expected/bytecoder.txt

@kalhauge kalhauge left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few extra as_posix() :), can you try to see if you can not change the output of the test/expected?

Comment thread test/expected/bytecoder.txt
@kalhauge

Copy link
Copy Markdown
Owner

@BilboBackend the tests are still there.

@kalhauge kalhauge self-requested a review November 18, 2025 07:37

@kalhauge kalhauge left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kalhauge kalhauge merged commit c1d5aa9 into main Nov 18, 2025
2 checks passed
@kalhauge kalhauge deleted the fix-buildcmd branch November 18, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants