Test all operating systems#43
Merged
Merged
Conversation
…r both mac and windows)
…nymore :V tried to fix it, as this made the tests fail. fixed it in some other places than cli, as am afraid could come up randomly
…ay (they need docker that has it setup)
…ndows when installing docker desktop anyway
kalhauge
requested changes
Nov 17, 2025
kalhauge
left a comment
kalhauge
left a comment
Owner
There was a problem hiding this comment.
Looks really good!
One improvement would be to encapsulate the "docker" command into something resuable.
| f"{suite.workfolder}:/workspace", | ||
| docker, | ||
| ] | ||
| docker_cmd = get_docker_command() |
Owner
There was a problem hiding this comment.
Looks good!
Can you refactor this so that it returns a docker object with a run method instead which we can use to replace the commands below?
Comment on lines
581
to
587
| run( | ||
| cmd | ||
| + ["javac", "-d", "target/classes"] | ||
| + list(a.relative_to(suite.workfolder) for a in suite.sourcefiles()), | ||
| + [a.relative_to(suite.workfolder).as_posix() for a in suite.sourcefiles()], | ||
| logerr=log.warning, | ||
| logout=log.info, | ||
| timeout=600, |
Owner
There was a problem hiding this comment.
This could be the following instead, incapsulating all the weird docker details?
docker.run(["javac", "-d", "target/classes"]
+ [a.relative_to(suite.workfolder).as_posix() for a in suite.sourcefiles()],
logerr=log.warning,
logout=log.info,
timeout=600,
)
Collaborator
Author
There was a problem hiding this comment.
should be fine now, i hope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and a few fixes I needed on the way to make it work