Open
Conversation
e1eb59a to
f166cbd
Compare
usha1830
reviewed
Mar 10, 2022
Collaborator
usha1830
left a comment
There was a problem hiding this comment.
Is this based on Fedora deps script?
How did you get the list of tools/deps needed?
Owner
Author
|
Github ci pipeline |
Collaborator
|
How do I verify this? |
d8c6ced to
f591e3d
Compare
Owner
Author
|
Tested on fresh ubuntu 18.04 and 20.04 install, could not see any error. |
f591e3d to
1ab0007
Compare
Owner
Author
|
Testing should be done using ctest -R . -j16(even ci uses this) , instead of make check. some ubpf tests fails with make-check |
usha1830
approved these changes
Mar 11, 2022
Collaborator
usha1830
left a comment
There was a problem hiding this comment.
Verified on my Ubuntu 18.04 machine.
All backends tests are passing with make check as well as ctest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After executing this script, we can build and test p4c without any issue atleast on ubuntu 20.04.