Set Up An Avo Installer - #52
Open
kanejamison wants to merge 7 commits into
Open
Conversation
Pages controller now reads slug from params[:page] (set via route defaults) before falling back to path parsing. Closes a theoretical query string override attack on bunko_page routes.
sample_data task now writes a proper root route instead of bunko_page :home, path: "/" when generating a home page. README updated with Avo integration docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
rails bunko:avo:installtask that generates an Avo admin resource for Bunko posts, plus a security fix for the pages controller and sample data home page routing.What changed
Avo installer (
rails bunko:avo:install)app/avo/resources/post.rbwith main content area + metadata sidebar layoutapp/avo/filters/post_type_filter.rb,publish_post.rb, andunpublish_post.rbactionsEDITOR=env var:markdown(default, Marksmith),rhino,tiptap,trix,textareaPages controller security fix
params[:page](set via route defaults) before falling back to path parsingGET /about?page=../../somethingSample data home page routing
bunko:sample_datanow writesroot "pages#show", defaults: {page: "home"}instead ofbunko_page :home, path: "/"Notes / WIP
tiptapandrhinodepend on third-party Avo field gems — documented in README but not verified end-to-endTest coverage
params[:page]resolution and query string attack