Repository navigation
Feat: sound sort ( title, size ) - #19
Merged
Merged
Conversation
Comment on lines
+21
to
+22
| - name: Validate registry | ||
| run: npx shadcn@latest registry validate |
Contributor
There was a problem hiding this comment.
This workflow fetches shadcn@latest on every pull request instead of using the version declared by the repo. When a new CLI release changes validation behavior, unchanged commits can start failing or passing differently, so the PR check can become nondeterministic.
Suggested change
| - name: Validate registry | |
| run: npx shadcn@latest registry validate | |
| - name: Validate registry | |
| run: npx shadcn@4.6.0 registry validate |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| @@ -0,0 +1 @@ | |||
| {"sessionId":"3133fa38-a5db-455a-8c79-6cc0fa16355d","pid":21111,"procStart":"Mon Jun 8 16:24:38 2026","acquiredAt":1780992158299} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
This file records a live local process lock with a sessionId, pid, and acquisition timestamp. Once it is committed, other checkouts can see stale lock state and skip or block scheduled task work even though the original process only existed on one machine.
Suggested change
| {"sessionId":"3133fa38-a5db-455a-8c79-6cc0fa16355d","pid":21111,"procStart":"Mon Jun 8 16:24:38 2026","acquiredAt":1780992158299} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR adds URL-backed sorting to the sounds catalog. The main changes are:
SoundSortcontrol for title and size ordering.useFilterStateand derived list work intouseGlobalFilters.Confidence Score: 4/5
This looks safe to merge after a couple of cleanup fixes.
.github/workflows/registry-validate.yml and .claude/scheduled_tasks.lock.
Important Files Changed
Reviews (1): Last reviewed commit: "feat: make pre-build sort" | Re-trigger Greptile