Skip to content

Feat: sound sort ( title, size ) - #19

Merged
kapishdima merged 4 commits into
mainfrom
feat/sort
Jun 9, 2026
Merged

kapishdima merged 4 commits into
mainfrom
feat/sort

Conversation

@kapishdima

@kapishdima kapishdima commented Jun 9, 2026 •

Copy link
Copy Markdown
Owner

Greptile Summary

This PR adds URL-backed sorting to the sounds catalog. The main changes are:

  • Adds a SoundSort control for title and size ordering.
  • Splits filter URL state into useFilterState and derived list work into useGlobalFilters.
  • Builds pre-sorted sound variants before filtering the catalog.
  • Updates selection and grid code to use the lighter filter-state hook.
  • Adds a registry validation workflow for pull requests.

Confidence Score: 4/5

This looks safe to merge after a couple of cleanup fixes.

  • The sound sorting and filter-state changes keep the current catalog path working.
  • The new workflow can behave differently when the external CLI changes.
  • A committed local lock file can interfere with scheduled task tooling in other checkouts.

.github/workflows/registry-validate.yml and .claude/scheduled_tasks.lock.

Important Files Changed

Filename Overview
hooks/use-global-filters.ts Adds shared URL-backed query/category/sort state and filters pre-sorted catalog variants.
lib/sound-filters.ts Adds sort keys and precomputed title/size sort variants for sound filtering.
components/sounds/sound-sort.tsx Adds the select UI for changing the active sound sort.
.github/workflows/registry-validate.yml Adds PR registry validation, but fetches the latest CLI at runtime.

Reviews (1): Last reviewed commit: "feat: make pre-build sort" | Re-trigger Greptile

Greptile also left 2 inline comments on this PR.

@kapishdima
kapishdima marked this pull request as ready for review June 9, 2026 08:33
@kapishdima
kapishdima merged commit 7cbfbb3 into main Jun 9, 2026
1 check passed
@kapishdima
kapishdima deleted the feat/sort branch June 9, 2026 08:33
Comment on lines +21 to +22
- name: Validate registry
run: npx shadcn@latest registry validate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Pin registry validation

This workflow fetches shadcn@latest on every pull request instead of using the version declared by the repo. When a new CLI release changes validation behavior, unchanged commits can start failing or passing differently, so the PR check can become nondeterministic.

Suggested change
- name: Validate registry
run: npx shadcn@latest registry validate
- name: Validate registry
run: npx shadcn@4.6.0 registry validate

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@@ -0,0 +1 @@
{"sessionId":"3133fa38-a5db-455a-8c79-6cc0fa16355d","pid":21111,"procStart":"Mon Jun 8 16:24:38 2026","acquiredAt":1780992158299} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Remove local lock

This file records a live local process lock with a sessionId, pid, and acquisition timestamp. Once it is committed, other checkouts can see stale lock state and skip or block scheduled task work even though the original process only existed on one machine.

Suggested change
{"sessionId":"3133fa38-a5db-455a-8c79-6cc0fa16355d","pid":21111,"procStart":"Mon Jun 8 16:24:38 2026","acquiredAt":1780992158299}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants