Reapply "fix: #291 停止を待つ側の余裕を取り戻す (#299)" (#376) - #443
Merged
Merged
Conversation
This reverts commit 4fa160a (the revert of #299), restoring #299's changes byte for byte, per the breaker decision on #291. The later #419 edit to tests/test_watch_stop.bats is kept; the revert applied without conflicts. Refs #291 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gd6MbRAYGpkDzHAk1XZroZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
PR #376（#299 の revert）を戻し、#299 の変更を再適用する。Issue #291 の breaker 断定による。
Refs #291
変更
git revert 4fa160a（#376 の squash merge commit）で作成した。衝突は無い。tests/test_helper.bashtests/test_wait_helpers.batstests/test_watch_stop.batstests/wait_helper_elapsed.pytests/watch_stop_helper.bashtests/watcher_term_latency.pybyte 単位で戻っていることの確認
git diff -R 4fa160a^ 4fa160aと、この commit の差分の +/- 行が一致する4fa160a^（revert 前の main）と完全に同じ内容であるtests/test_watch_stop.batsだけは revert 前と異なる。revert: restore pre-#299 wait behavior #376 の後に PR test: bounded watcherのchild_rc異常終了分岐へ専用対照を追加 #419 がこのファイルを変更しており、その変更を残したまま fix: #291 停止を待つ側の余裕を取り戻す #299 の差分を適用したためである扱わない範囲
README への影響
なし。
tests/配下だけの変更である。試験
tests/test_wait_helpers.batstests/test_watch_stop.batscheck-enforced-assertions.sh🤖 Generated with Claude Code
https://claude.ai/code/session_01QCtgi8wVJDRaMwXHZmkHqT