fix: resolve syntax error and implement coordinator API contract tests - #229
fix: resolve syntax error and implement coordinator API contract tests#229priyankbhikadiya wants to merge 1 commit into
Conversation
|
@priyankbhikadiya is attempting to deploy a commit to the karagoz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@priyankbhikadiya Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
API contract testleri incelendi ve PR dalında 23/23 test geçti. Ancak güncel |
close #27
What & Why
One or two paragraph summary of the change and the problem it solves. Link the issue with
Closes #…orRefs #….Touched surface
Tick every layer this PR changes:
frontend/— React + Vite bridge UIpackages/sdk/— shared TypeScript SDKcoordinator/— order book + REST/WS serviceresolver/— community resolver runnerrelayer/— legacy v1 listener / watchdog (changes here need extra scrutiny)contracts/— Solidity v2 (HTLCEscrow,ResolverRegistry)soroban/— Stellar Soroban contracts (oversync-htlc,oversync-resolver-registry)docs/— documentation only.github/workflows/,docker,env.example)Settlement & refund semantics
Critical for SCF / investor review. If any box is checked, the PR must also update
docs/REVIEW_RESPONSE.mdand link the updated section in the PR description.Tests run
Tick the matches your change and paste the outcome below. Commands mirror the matrix in
CONTRIBUTING.md.pnpm --filter @oversync/sdk build && pnpm --filter @oversync/sdk exec tsc --noEmitpnpm --filter @oversync/sdk testpnpm --filter @oversync/coordinator exec tsc --noEmit && pnpm --filter @oversync/coordinator testpnpm --filter @oversync/resolver exec tsc --noEmit && pnpm --filter @oversync/resolver testpnpm --filter @oversync/frontend exec tsc --noEmit && pnpm --filter @oversync/frontend testpnpm --filter @oversync/contracts compile && pnpm --filter @oversync/contracts exec hardhat test test/v2/HTLCEscrow.test.ts test/v2/ResolverRegistry.test.tscd soroban && stellar contract build && cargo test --release(cd contracts && forge test --match-path "test/foundry/*" -v)(Solidity fuzz / invariant)pnpm test:e2e(cross-chain differential harness)node scripts/verify-addresses.mjs— required if addresses, configs, orenv.examplechangenode scripts/check-evidence-links.mjs— advisory; required if docs links changeFree-form outcome:
UI / evidence artefacts
Required if the PR changes the frontend, observability, dashboards, or any docs that claim status, metrics, or addresses. Otherwise write
n/a.curlsnippet + JSON response sample pasted belowdocs/examples/metrics-snapshot.example.json(or new JSON in PR)Secrets, logging, and PII risk
.envcontent, wallet mnemonics, or preimages added to the repoconsole.*/logger.*line that prints secrets, preimages, signed payloads, or PIIVITE_*andesbuild.droppolicy still holds)Public proof links (SCF / investor evidence)
Only required for SCF tranche PRs or investor evidence packs. Otherwise write
n/a./metrics,/health, public Grafana):https://github.com/karagozemin/OverSync/actions/runs/…):Breaking change & rollback
Reviewer checklist (for the PR author to self-verify)
git revertrestores prior state