fix(resolver): enforce coordinator network agreement - #243
Merged
karagozemin merged 1 commit intoAug 31, 2026
Conversation
|
@emirykl is attempting to deploy a commit to the karagoz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@emirykl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
Network agreement değişikliği ve resolver testleri incelendi; resolver testleri 57/57 geçiyor. Ancak #248/#249/#247/#244 merge’lerinden sonra bu branch güncel |
emirykl
force-pushed
the
drips/issue-232-scf-high-easy-verify-coordinator-and-resolver-ne
branch
from
August 31, 2026 18:15
d06fbfc to
e3f6b7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/readinessTest evidence
resolver/src/network-agreement.tspassedgit diff --checkpassedFixes #232
Verification
Focused resolver network agreement tests: 2 passed with Vitest 2.1.9Standalone TypeScript check for network-agreement.ts passedgit diff --check passedFull workspace tests unavailable due pre-existing broken pnpm lockfile and missing installed dependenciesDiagnostics
Recovered command failures:
/bin/zsh -lc "sed -n '1,320p' resolver/src/check.ts && sed -n '1,260p' resolver/src/config.ts"(1),/bin/zsh -lc "rg -n \"ETHEREUM_CHAIN_ID|STELLAR_NETWORK_PASSPHRASE|NETWORK_MODE\" env.example* .env.example* coordinator resolver --glob '*'"(1),/bin/zsh -lc 'git status --short && node -v && pnpm -v'(1),/bin/zsh -lc 'COREPACK_HOME=/tmp/oversync-corepack pnpm install --frozen-lockfile'(1),/bin/zsh -lc 'COREPACK_HOME=/tmp/oversync-corepack corepack pnpm@9.15.0 install --frozen-lockfile'(1),/bin/zsh -lc '../node_modules/.bin/tsc -p resolver/tsconfig.json --noEmit'(127),/bin/zsh -lc "ls '/Users/emir/Desktop/grantfox drips agents/node_modules/.bin/tsc' && '/Users/emir/Desktop/grantfox drips agents/node_modules/.bin/tsc' -p resolver/tsconfig.json --noEmit"(2),/bin/zsh -lc 'npx --yes vitest@2.1.9 run resolver/test/network-agreement.test.ts --no-watchman'(1),/bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run resolver/test/network-agreement.test.ts --no-watchman'(1),/bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run resolver/test/network-agreement.test.ts'(1),/bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run --config resolver/vitest.temp.config.ts resolver/test/network-agreement.test.ts'(1),/bin/zsh -lc "npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run --config <(printf 'export default { test: { environment: \"node\" } }') resolver/test/network-agreement.test.ts"(1),/bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run --config resolver/vitest.temp.config.ts resolver/test/readiness.test.ts'(1)Pre-existing failures
These checks also fail on
masterwithout this change, so they are not caused by this PR:/bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run --config resolver/vitest.temp.config.ts resolver/test/readiness.test.ts'