Skip to content

fix(resolver): enforce coordinator network agreement - #243

Merged
karagozemin merged 1 commit into
karagozemin:masterfrom
emirykl:drips/issue-232-scf-high-easy-verify-coordinator-and-resolver-ne
Aug 31, 2026
Merged

fix(resolver): enforce coordinator network agreement#243
karagozemin merged 1 commit into
karagozemin:masterfrom
emirykl:drips/issue-232-scf-high-easy-verify-coordinator-and-resolver-ne

Conversation

@emirykl

@emirykl emirykl commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • publish a SHA-256 fingerprint of the coordinator Stellar network passphrase from /readiness
  • compare coordinator and resolver Ethereum chain IDs and Stellar network passphrases during resolver readiness
  • fail resolver startup on a detected network mismatch while preserving warning behavior for unavailable coordinators
  • add matching, mismatch, and passphrase-redaction tests

Test evidence

  • Focused network agreement tests: 2 passed with Vitest 2.1.9
  • Standalone TypeScript check for resolver/src/network-agreement.ts passed
  • git diff --check passed
  • Full workspace tests could not run because the repository lockfile has a pre-existing missing dependency entry and required workspace dependencies are unavailable.

Fixes #232

Verification

  • Focused resolver network agreement tests: 2 passed with Vitest 2.1.9
  • Standalone TypeScript check for network-agreement.ts passed
  • git diff --check passed
  • Full workspace tests unavailable due pre-existing broken pnpm lockfile and missing installed dependencies

Diagnostics

Recovered command failures: /bin/zsh -lc "sed -n '1,320p' resolver/src/check.ts && sed -n '1,260p' resolver/src/config.ts" (1), /bin/zsh -lc "rg -n \"ETHEREUM_CHAIN_ID|STELLAR_NETWORK_PASSPHRASE|NETWORK_MODE\" env.example* .env.example* coordinator resolver --glob '*'" (1), /bin/zsh -lc 'git status --short && node -v && pnpm -v' (1), /bin/zsh -lc 'COREPACK_HOME=/tmp/oversync-corepack pnpm install --frozen-lockfile' (1), /bin/zsh -lc 'COREPACK_HOME=/tmp/oversync-corepack corepack pnpm@9.15.0 install --frozen-lockfile' (1), /bin/zsh -lc '../node_modules/.bin/tsc -p resolver/tsconfig.json --noEmit' (127), /bin/zsh -lc "ls '/Users/emir/Desktop/grantfox drips agents/node_modules/.bin/tsc' && '/Users/emir/Desktop/grantfox drips agents/node_modules/.bin/tsc' -p resolver/tsconfig.json --noEmit" (2), /bin/zsh -lc 'npx --yes vitest@2.1.9 run resolver/test/network-agreement.test.ts --no-watchman' (1), /bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run resolver/test/network-agreement.test.ts --no-watchman' (1), /bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run resolver/test/network-agreement.test.ts' (1), /bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run --config resolver/vitest.temp.config.ts resolver/test/network-agreement.test.ts' (1), /bin/zsh -lc "npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run --config <(printf 'export default { test: { environment: \"node\" } }') resolver/test/network-agreement.test.ts" (1), /bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run --config resolver/vitest.temp.config.ts resolver/test/readiness.test.ts' (1)

Pre-existing failures

These checks also fail on master without this change, so they are not caused by this PR: /bin/zsh -lc 'npm_config_cache=/tmp/oversync-npm-cache npx --yes vitest@2.1.9 run --config resolver/vitest.temp.config.ts resolver/test/readiness.test.ts'

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@emirykl is attempting to deploy a commit to the karagoz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@emirykl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@karagozemin

Copy link
Copy Markdown
Owner

Network agreement değişikliği ve resolver testleri incelendi; resolver testleri 57/57 geçiyor. Ancak #248/#249/#247/#244 merge’lerinden sonra bu branch güncel master ile conflict durumuna geldi ve GitHub merge’i reddetti. Lütfen güncel master üzerine rebase/merge edip çatışmaları çözerek yeni commit push edin; sonra yeniden kontrol edeceğim.

@emirykl
emirykl force-pushed the drips/issue-232-scf-high-easy-verify-coordinator-and-resolver-ne branch from d06fbfc to e3f6b7e Compare August 31, 2026 18:15
@karagozemin
karagozemin merged commit e434c3c into karagozemin:master Aug 31, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SCF high][easy] Verify coordinator and resolver network agreement

2 participants