Activity Done - #136
Open
shahriar3174 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the "Index Out of Bounds" crash and logic errors introduced by the name deletion feature. The primary fix involves updating CustomAdapter to return names.size dynamically instead of a hardcoded value, ensuring the adapter stays in sync with the underlying data. Additionally, the deletion logic in MainActivity was refined to safely update the spinner selection using coerceAtMost, preventing crashes when the last item in the list is removed. I also implemented state handling to clear the TextView and disable the delete button once the list is empty, ensuring a stable and intuitive user experience.