Fix delete button crashes - #148
Open
kvanc99peltek wants to merge 1 commit into
Open
Conversation
Bug 1: CustomAdapter.getCount() was hardcoded to return 5 instead of the actual list size. After deleting a name, the adapter still reported 5 items, causing an IndexOutOfBoundsException. Fixed by returning names.size. Bug 2: The delete button had no guard for an empty list. Pressing delete after all names were removed caused a crash. Fixed by checking names.isNotEmpty() before removing, and clearing the text view when the list becomes empty.
kvanc99peltek
force-pushed
the
fix-bugs
branch
from
February 18, 2026 21:21
85cd55c to
1de4462
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCount():CustomAdapter.getCount()was always returning5instead ofnames.size. After deleting a name the adapter still thought there were 5 items, so it tried to access indices that didn't exist anymore and threw anIndexOutOfBoundsException. Fixed it by returningnames.sizeinstead.removeAt()was called on an empty list. Added anisNotEmpty()check before removing, and also clear the text view when the list is empty.