bug fix - #149
Open
jeeae3 wants to merge 2 commits into
Open
Conversation
fixed delete button, list size counter, update spinner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug: crashes when delete buttton is clicked
fix: created conditions for when names list is empty or not
if not empty
makes sure its in range of names list length
checks spinner item selected position
sets spinner to that selected position
sets text view to the string of position selected
if empty
the text view is blank and delete button is not displayed
get count returns size of names list
get item also should handle if names list is empty