lab activity 5 - #150
Open
susmithametta9-debug wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tackled two main issues that were causing the app to crash or behave unexpectedly.
1.
Incorrect Item Count: The first bug was in the CustomAdapter. The adapter was hardcoded to always report that it had 5 items, even after you deleted one. When you tried to select a name after a deletion, the app would crash because it was trying to access data that wasn't there anymore. I fixed this by making the adapter report the actual size of your name list.
2.
Deleting from an Empty List: The second issue was in the main screen's logic. The app would crash if you tried to delete a name when the list was already empty and I added a simple check to make sure the app only tries to delete a name if there are names in the list to begin with. I also made sure that when you delete the last name, the text on the screen clears out, so it doesn't keep showing a name that's been removefd