View model2 - #9
Open
dominiquebissey wants to merge 5 commits into
Open
Conversation
Fixed the roll button to change the die roll when clicked.
Fixed the roll button to change the die roll when clicked. Added saveInstanceState to save the value of the die roll when the screen in rotated.
Fixed the roll button to change the die roll when clicked. Added saveInstanceState to save the value of the die roll when the screen in rotated. Added factory method to change number of die sides and set 6 as the default. Fixed the rollDieButton to use work with the newInstance of the die sides. Added second fragmentContainerView to add second die that can be rolled. Added DieViewModel and implemented its usage in the DieFragment.
Fixed the roll button to change the die roll when clicked. Added saveInstanceState to save the value of the die roll when the screen in rotated. Added factory method to change number of die sides and set 6 as the default. Fixed the rollDieButton to use work with the newInstance of the die sides. Added second fragmentContainerView to add second die that can be rolled. Added DieViewModel and implemented its usage in the DieFragment. Added rollDie function to ViewModel with fixed die sides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.