Refactor karva_test_semantic for readability and discoverability#684
Merged
MatthewMckee4 merged 3 commits intomainfrom Apr 15, 2026
Merged
Refactor karva_test_semantic for readability and discoverability#684MatthewMckee4 merged 3 commits intomainfrom
MatthewMckee4 merged 3 commits intomainfrom
Conversation
Consolidate the PyO3 surface, simplify the test-variant classification logic, and extract the Python interpreter attachment helpers out of `utils.rs` into their own module.
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readability refactors across
karva_test_semantic, no behaviour change.classify_test_resultloses its eleven-argument signature and three-level nested match in favour of a smallVariantReportCtxstruct with early returns. Thefunctions/module now follows the samemod.rsbarrel +python.rsPyO3 surface convention astags/andfixtures/. Python interpreter attachment moves out ofutils.rsinto a newsrc/py_attach.rswithattach_with_outputreplacing the misnamedattach_with_project.Test plan
ci