Remove cross-run duration weighting from test partitioning#686
Open
MatthewMckee4 wants to merge 2 commits intomainfrom
Open
Remove cross-run duration weighting from test partitioning#686MatthewMckee4 wants to merge 2 commits intomainfrom
MatthewMckee4 wants to merge 2 commits intomainfrom
Conversation
Merging this PR will degrade performance by 18.75%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | karva_benchmark |
24.7 s | 30.4 s | -18.75% |
Comparing remove-duration-cache (73468bd) with main (faef1bf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The runner used to read the previous run's per-test durations from the cache and weight the partitioning algorithm by those timings to balance worker load. In practice the added complexity wasn't paying off, so this drops the cross-run read entirely and partitions using uniform test counts instead. Module-aware bin-packing is preserved (tests in the same module stay on one worker when possible; large modules still split across workers) — only the duration-based weighting is gone.
--durations Nstill works; per-worker durations are still written and aggregated within a run.Test plan
ci