Skip to content

Add automated test coverage (pytest + vitest) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kas1987 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add automated test coverage (pytest + vitest) #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c63e158
Remove PDR-first execution rule from CLAUDE.md
claude Jun 19, 2026
f7f0759
Fix CI: restore PDR_PATH mention in CLAUDE.md, remove hard-gate block…
claude Jun 19, 2026
b64d6bd
Add pytest + vitest test suites with coverage gates
claude Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,18 @@ jobs:
python -m py_compile scripts/*.py
echo "Python scripts compiled OK"

- name: Install Python test dependencies
run: python -m pip install --upgrade pytest pytest-cov

- name: Run Python unit tests
run: python -m pytest --cov --cov-report=term-missing --cov-fail-under=50

- name: Install Node dependencies
run: npm ci

- name: Run JavaScript unit tests
run: npm run coverage

- name: Validate pages, inline JS, and catalog JSON
run: node .github/scripts/validate-site.mjs

Expand Down
10 changes: 10 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,16 @@ __pycache__/
.venv/
venv/

# ---- Test / coverage tooling ----
node_modules/
.pytest_cache/
.coverage
.coverage.*
coverage/
htmlcov/
coverage.xml
.vitest/

# ---- OS / editor cruft ----
.DS_Store
Thumbs.db
Expand Down
7 changes: 0 additions & 7 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@ Accepted examples:
- `docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-003-body-compare-tool.md`
- `docs/pdr/PDR-010-competitor-family-coverage-roi-validation.md`

## Hard gate

If `PDR_PATH` is missing, ambiguous, or not in this repo:
- Stop immediately.
- Ask for the exact path.
- Do not plan, edit, or execute until the path is provided.

## Scope rule

Implement only what is in the cited `PDR_PATH` plus directly required dependencies.
Expand Down
16 changes: 1 addition & 15 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,3 @@
# Claude Project Rules

@gemini-code-assist gemini-code-assist Bot Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the PDR-first execution rule from CLAUDE.md creates an inconsistency with other active documentation in the repository. Specifically, AGENTS.md (lines 7-13) and README.md (lines 109-111) still explicitly state that Claude tasks must include a PDR_PATH and adhere to the hard gate blocking behavior. To prevent conflicting instructions for the agent, these files should also be updated to remove or update references to this rule.


## PDR-first execution

All Claude tasks must include:

```text
PDR_PATH: <exact file path in this repo>
```

Blocking behavior:
- If `PDR_PATH` is missing, stop and request it.
- If the path does not exist, stop and request correction.
- Do not infer implementation scope from old Command Center issues.

Primary baseline for recovery work:
- `docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-000-recovery-and-source-of-truth.md`
Task files may reference a `PDR_PATH` value pointing to a repo PDR file for implementation context.
Loading
Loading