Conversation
UgnilJoZ
force-pushed
the
fix/unnecessary-copy
branch
from
September 8, 2026 21:18
23565a3 to
7ee5eec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading a Wikidata dump with
Bz2Decoder::openfromparallel_bzip2_decoder, I noticed my program tried to reserve 96 GiB of memory. The reason for that is that the crate copies the full memory-mapped file into the heap while scanning for blocks, which negates the advantage of using mmap. Removing the copy lets the crate behave as expected. Unfortunately I had to modify the signature ofscan_blocks, which is a breaking change.