Skip to content

bump to v4.29.0#137

Open
Whysoserioushah wants to merge 11 commits intokbuzzard:mainfrom
Whysoserioushah:edison/bump_29
Open

bump to v4.29.0#137
Whysoserioushah wants to merge 11 commits intokbuzzard:mainfrom
Whysoserioushah:edison/bump_29

Conversation

@Whysoserioushah
Copy link
Copy Markdown
Contributor

No description provided.

@Whysoserioushah Whysoserioushah changed the title [WIP] bump to v4.29.0 bump to v4.29.0 Apr 1, 2026
public import Mathlib.RepresentationTheory.Homological.GroupCohomology.LongExactSequence
public import Mathlib.RepresentationTheory.Induced

public import Mathlib
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove this?

-- /--
-- The restriction functor `Rep R G ⥤ Rep R H` for a subgroup `H` of `G`.
-- -/
-- def res (f : H →* G) : Rep R G ⥤ Rep R H := Action.res (ModuleCat R) f
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove this?

instance : (res% R f).IsRightAdjoint :=
(indResAdjunction' R f).isRightAdjoint
-- instance : (res% R f).IsRightAdjoint :=
-- (indResAdjunction' R f).isRightAdjoint
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all this dead code? Unless you need it for some reason?

(M ↓ e.toMonoidHom).norm.hom = M.norm.hom := by
section

set_option linter.unusedFintypeInType false
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this all about?

public import Mathlib.Data.Finsupp.Notation
public import Mathlib.FieldTheory.Galois.NormalBasis
public import Mathlib.RepresentationTheory.FiniteIndex
public import Mathlib
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove this?

-- The map `coind₁'_ι` intertwines a representation `ρ` of `G` on `V` with the
-- representation `ρ.coind₁'` of `G` on `G → V`.
-- -/
-- lemma coind₁'_ι_comm (g : G) : coind₁' ρ g ∘ₗ coind₁'_ι = coind₁'_ι ∘ₗ ρ g := by ext; simp
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove this?

Representation.coind₁AsPi_apply, Pi.ofNat_apply]
-- This is equivalent to...
change ∀ f : G → A, (∀ x, ∑ h : H, f (x * h) = 0) → f ∈ Representation.Coinvariants.ker _
-- change ∀ f : G → A, (∀ x, ∑ h : H, f (x * h) = 0) → f ∈ Representation.Coinvariants.ker _
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this?

simp only [res_obj_V, res_obj_ρ, AddSubmonoidClass.coe_finset_sum, SetLike.val_smul,
coe_finset_sum, coe_smul, Finset.sum_apply, Pi.smul_apply, single_apply, Finset.sum_boole,
smul_eq_mul]
-- intro a
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

-- instance : HasForget₂ (Rep.{w} k G) Ab where
-- forget₂ := forget₂ (Rep k G) (ModuleCat k) ⋙ (forget₂ _ _)

-- instance : (forget₂ (Rep.{w} k G) Ab).Additive := ⟨rfl⟩
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill this dead code?

(forget₂ (Rep k G) (ModuleCat k)).map f = f.hom := rfl
-- @[simp]
-- lemma Rep.forget₂_map {M N : Rep k G} (f : M ⟶ N) :
-- (forget₂ (Rep k G) (ModuleCat k)).map f = f.hom := rfl
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill this dead code?

public import Mathlib.RepresentationTheory.Basic
public import Mathlib.RepresentationTheory.Rep
public import Mathlib.Data.Finsupp.Single
-- public import Mathlib.RepresentationTheory.Basic
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill this?

-- instance :
-- MulActionHomClass (Action.HomSubtype (ModuleCat R) G (leftRegular R G) (trivial R G R))
-- R (leftRegular R G) (trivial R G R) where
-- map_smulₛₗ f := map_smul f.val
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill this dead code?

import ClassFieldTheory.Mathlib.Topology.Algebra.Ring.Basic
import ClassFieldTheory.Mathlib.Topology.Algebra.Valued.NormedValued
import ClassFieldTheory.Mathlib.Topology.Algebra.Valued.ValuativeRel
import ClassFieldTheory.Tactic.Dualize
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to stop using the module system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants