Skip to content

Configure Agent-managed label shard pools - #606

Open
zroubalik wants to merge 8 commits into
kedify:mainfrom
zroubalik:feat/label-sharding
Open

zroubalik wants to merge 8 commits into
kedify:mainfrom
zroubalik:feat/label-sharding

Conversation

@zroubalik

@zroubalik zroubalik commented Sep 23, 2026 •

Copy link
Copy Markdown

Configure Agent label-shard pools through Helm values and a ConfigMap, and register each KEDA shard with an exact selector and paired KPA identity. Validate incompatible settings and grant the additional reads/ConfigMap patch permission needed by assignment. Preserve shard identity in the existing observed-status CRD schema.

The KEDA chart sets the native WATCH_LABEL_SELECTOR environment variable; the paired KPA chart uses its separate --watch-label-selector flag. Sharded releases require compatible controller images. Existing defaults remain unsharded, and this feature PR does not change release versions. Positive and negative render coverage runs in chart CI.

Refs https://github.com/kedify/agent/issues/663.

Validation: helm lint keda, focused sharding and existing KPA render checks, and staged-dependency rendering passed.

Companion PRs

Copilot AI lite review requested due to automatic review settings September 23, 2026 22:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Address the KEDA dependency release path, correct the RBAC test assertion, and bound tenant reference components to 63 characters.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity

Open (2)
What changed in this PR

Adds optional Helm-configured label-shard pools for Agent-managed KEDA/KPA deployments, including selector propagation, validation, RBAC, status fields, documentation, and CI coverage.

Changes:

  • Adds Agent pool configuration and ConfigMap rendering.
  • Adds KEDA shard identities, selectors, and validation.
  • Updates RBAC, CRD status, documentation, and render tests.
File Description
kedify-agent/​values.yaml Adds shard pool values.
kedify-agent/​test/​sharding-rendering.sh Adds positive and negative render tests.
kedify-agent/​templates/​agent-sharding-configmap.yaml Renders and validates pool configuration.
kedify-agent/​templates/​agent-rbac.yaml Adds shard permissions.
kedify-agent/​templates/​agent-deployment.yaml Passes pool configuration to the Agent.
kedify-agent/​README.md Documents Agent sharding.
kedify-agent/​files/​crds/​kedify-configuration.yaml Preserves shard status fields.
keda/​values.yaml Adds shard identity values.
keda/​values.schema.json Defines shard value validation.
keda/​templates/​manager/​deployment.yaml Configures operator label filtering.
keda/​templates/​kedify-tenant-registration-configmap.yaml Registers shard and KPA identity.
keda/​templates/​_kedify-helpers.tpl Validates and derives selectors.
keda/​README.md Documents KEDA sharding.
.github/​workflows/​ci-kedify-agent.yml Runs Agent shard tests.
.github/​workflows/​ci-core.yml Adds core shard validation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread keda/templates/manager/deployment.yaml Outdated
Comment thread kedify-agent/test/sharding-rendering.sh Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Environment-backed configuration can bypass the ScalingGroups safety validation.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 High severity · 1 Medium severity

Open (3)

Comment thread keda/templates/_kedify-helpers.tpl Outdated
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
…re#663

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

@kedifybot kedifybot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent validation at addb38078bb2aaed1e656c8c9a6e16e8fc3b7a2d: bash kedify-agent/test/sharding-rendering.sh passed, including disabled/default rendering and configured shard values. I found no chart-specific defect in this review; the remaining runtime findings are in the private Agent/KEDA implementation and documentation reviews.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants