Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the KEDA dependency release path, correct the RBAC test assertion, and bound tenant reference components to 63 characters.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds optional Helm-configured label-shard pools for Agent-managed KEDA/KPA deployments, including selector propagation, validation, RBAC, status fields, documentation, and CI coverage.
Changes:
- Adds Agent pool configuration and ConfigMap rendering.
- Adds KEDA shard identities, selectors, and validation.
- Updates RBAC, CRD status, documentation, and render tests.
| File | Description |
|---|---|
kedify-agent/values.yaml |
Adds shard pool values. |
kedify-agent/test/sharding-rendering.sh |
Adds positive and negative render tests. |
kedify-agent/templates/agent-sharding-configmap.yaml |
Renders and validates pool configuration. |
kedify-agent/templates/agent-rbac.yaml |
Adds shard permissions. |
kedify-agent/templates/agent-deployment.yaml |
Passes pool configuration to the Agent. |
kedify-agent/README.md |
Documents Agent sharding. |
kedify-agent/files/crds/kedify-configuration.yaml |
Preserves shard status fields. |
keda/values.yaml |
Adds shard identity values. |
keda/values.schema.json |
Defines shard value validation. |
keda/templates/manager/deployment.yaml |
Configures operator label filtering. |
keda/templates/kedify-tenant-registration-configmap.yaml |
Registers shard and KPA identity. |
keda/templates/_kedify-helpers.tpl |
Validates and derives selectors. |
keda/README.md |
Documents KEDA sharding. |
.github/workflows/ci-kedify-agent.yml |
Runs Agent shard tests. |
.github/workflows/ci-core.yml |
Adds core shard validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
…re#663 Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
…edacore#663 Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
66f30d6 to
addb380
Compare
kedifybot
left a comment
There was a problem hiding this comment.
Independent validation at addb38078bb2aaed1e656c8c9a6e16e8fc3b7a2d: bash kedify-agent/test/sharding-rendering.sh passed, including disabled/default rendering and configured shard values. I found no chart-specific defect in this review; the remaining runtime findings are in the private Agent/KEDA implementation and documentation reviews.


Configure Agent label-shard pools through Helm values and a ConfigMap, and register each KEDA shard with an exact selector and paired KPA identity. Validate incompatible settings and grant the additional reads/ConfigMap patch permission needed by assignment. Preserve shard identity in the existing observed-status CRD schema.
The KEDA chart sets the native
WATCH_LABEL_SELECTORenvironment variable; the paired KPA chart uses its separate--watch-label-selectorflag. Sharded releases require compatible controller images. Existing defaults remain unsharded, and this feature PR does not change release versions. Positive and negative render coverage runs in chart CI.Refs https://github.com/kedify/agent/issues/663.
Validation:
helm lint keda, focused sharding and existing KPA render checks, and staged-dependency rendering passed.Companion PRs