Use Recommender v0.2.0 and package its license terms - #16
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
README’s updated offline-analysis section still uses ambiguous wording and links to only one of the engine license texts, which can misdirect readers about where to find the full terms.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the CLI to use Kedify Recommender v0.2.0 and packages the required license/notice materials so releases and Homebrew installs correctly preserve the mixed licensing terms (Apache 2.0 for CLI-owned code, commercial/public-source terms for the bundled engine).
Changes:
- Bump
github.com/kedify/recommenderfrom v0.1.0 to v0.2.0. - Add component notice + bundled engine license texts and clarify licensing/subscription terms in README/NOTICE.
- Include LICENSE/NOTICE/license texts in GoReleaser archives and install them into
share/kedifyvia Homebrew.
File summaries
| File | Description |
|---|---|
| README.md | Adds subscription/trial guidance for offline analysis and clarifies mixed licensing. |
| NOTICE | Introduces a component notice describing the bundled engine’s licensing scope and obligations. |
| licenses/LicenseRef-Kedify-Public-Source-1.0.txt | Adds the Public Source Addendum 1.0 text to be distributed with releases. |
| licenses/LicenseRef-Kedify-Commercial-1.0.txt | Adds the Commercial Subscription License 1.0 text to be distributed with releases. |
| go.mod | Updates the recommender dependency to v0.2.0. |
| go.sum | Updates checksums for recommender v0.2.0. |
| .goreleaser.yaml | Ensures release archives contain LICENSE/NOTICE/engine license texts and Homebrew installs them under pkgshare. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
54
to
+58
| The offline command consumes a normalized snapshot and runs the same analysis engine | ||
| used by Kedify services. The request is: | ||
| used by Kedify services. Production analysis requires an active Kedify subscription | ||
| covering recommendations, including offline use. Evaluation and demos follow the | ||
| [engine license](licenses/LicenseRef-Kedify-Commercial-1.0.txt); using live workloads | ||
| or recommendations for operational decisions during a trial requires written trial |
zroubalik
enabled auto-merge (squash)
September 8, 2026 16:27
wozniakjan
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Recommender v0.2.0 for offline recommendation analysis. CLI-owned source remains Apache 2.0; the embedded engine is covered by Kedify Commercial 1.0 and Public Source 1.0. The README and component notice explain subscription, trial and offline scope while preserving earlier Apache grants.
Include both complete engine license texts, the CLI license and the component notice in every release archive and install them under
share/kedifythrough Homebrew. Command behavior and the existing single-binary architecture remain unchanged.Validation:
go vet ./...,go mod verify,go mod tidyandmake buildpassed.github.com/kedify/recommender v0.2.0.share/kedifyon all four Homebrew targets.GoReleaser reports the repository's existing
brewsconfiguration as deprecated; it remains functional and the snapshot release succeeds. Signing and publishing were skipped for local validation.