Skip to content

fix-ci - #1

Merged
josefkarasek merged 2 commits into
mainfrom
skill
Aug 13, 2026
Merged

josefkarasek merged 2 commits into
mainfrom
skill

Conversation

@josefkarasek

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
Copilot AI lite review requested due to automatic review settings August 13, 2026 14:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the scripts/common.py utilities to avoid importing PyYAML at module import time, which helps prevent failures in environments (e.g., CI steps) that import these helpers but don’t need YAML functionality.

Changes:

  • Removed the top-level import yaml from scripts/common.py.
  • Added deferred import yaml statements inside load_yaml() and parse_skill_frontmatter() so YAML is only required when those functions are called.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Signed-off-by: Josef Karasek <karasek.jose@gmail.com>
Copilot AI review requested due to automatic review settings August 13, 2026 14:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

scripts/common.py:39

  • Same as load_yaml(): when PyYAML isn’t installed, the import error here is hard to interpret for users running the script. Wrapping it with a short, actionable message would make failures clearer.
def parse_skill_frontmatter(skill_md_path: Path) -> dict[str, Any]:
    import yaml

scripts/common.py:30

  • If PyYAML isn’t installed, this will raise a generic ModuleNotFoundError: No module named 'yaml' without context. Consider catching it and raising a clearer message indicating PyYAML is an optional dependency and how to install it.

This issue also appears on line 37 of the same file.

def load_yaml(path: Path) -> Any:
    import yaml

    with path.open(encoding="utf-8") as handle:
        return yaml.safe_load(handle)

@josefkarasek
josefkarasek merged commit 3b4bfee into main Aug 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants